Fang Shih [:fang] Reporter
	Description • 10 years ago

Base on Pavel's feedback, there's some missing images that need to update.

	Fang Shih [:fang] Reporter
	Comment 1 • 10 years ago

Hi Pavel,
I've updated a set of email icon in bug 1010673, James has helped me on it with new icons. 
And for the app icon as below images is not missing image:

./apps/email/style/icons/Email_120@1.5x.png
./apps/email/style/icons/Email_120@2x.png
./apps/email/style/icons/Email_120@2.25x.png
./apps/email/style/icons/Email_135@1.5x.png
./apps/email/style/icons/Email_135@2x.png
./apps/email/style/icons/Email_135@2.25x.png
./apps/email/style/icons/Email_60@1.5x.png
./apps/email/style/icons/Email_60@2x.png
./apps/email/style/icons/Email_60@2.25x.png
./apps/email/style/icons/Email_90@1.5x.png
./apps/email/style/icons/Email_90@2x.png
./apps/email/style/icons/Email_90@2.25x.png

It's file naming issue. We just need to change those file name as below:

Settings_60.png to Settings.png
Settings_90.png to Settings@1.5x
Settings_120.png to Settings@2x.png
Settings_135.png to Settings@2.25x.png

Thanks!

	James Burke [:jrburke]
	Comment 2 • 10 years ago

Note that I plan to land the in-app email icons as part of landing the changeset in bug 950208, which hopefully can land soon if I get at minimum a "flag icon on" image. I will mark this bug as dependent on that visual refresh bug.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 3 • 10 years ago

\o/ :)

	Fang Shih [:fang] Reporter
	Comment 4 • 10 years ago

> Settings_60.png to Settings.png
> Settings_90.png to Settings@1.5x
> Settings_120.png to Settings@2x.png
> Settings_135.png to Settings@2.25x.png
> 
> Thanks!

Oh..sorry guys, I pasted the wrong copy. I mean to put 

Email_60.png to Email.png
Email_90.png to Email@1.5x
Email_120.png to Email@2x.png
Email_135.png to Email@2.25x.png

Sorry for the mistake : (

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 5 • 10 years ago

About Email_60.png, Email_90.png, Email_120.png, Email_135.png

We should avoid using @*x postfix naming in the manifest. Because during build time, build system will remove all images with @*x postfix and keep only one correct resource based on device pixel ratio.

	James Burke [:jrburke]
	Comment 6 • 10 years ago

Also, for those Email_ images, those are used in the webapp manifest for the "icons" section, and that section is based on explicit pixel sizes:

https://developer.mozilla.org/en-US/Apps/Build/Manifest#icons

so I think it makes sense to keep the names matching those sizes.

Now that bug 950208 has landed, is there anything more specific to do for this bug? 

Perhaps maybe just update the set of these Email_ icons here:

https://github.com/mozilla-b2g/gaia/tree/master/apps/email/style/icons

to match the sizes in that Manifest documentation link? Right now email has a 60, 90, 120, and 135 images.

Looking at that doc link, looks like we should add these sizes for completeness:

* 128
* 32
* 256

Going to needinfo Fang for these, and if this is the last thing for this bug, I can take this bug and generate a pull request for that change.

	Fang Shih [:fang] Reporter
	Comment 7 • 10 years ago

Hi James,
There is no more specific to do for this bug. For the app icon, Peter already updated the whole set of the app icon on Bug 1014591. I think we are good now! Thanks!

	James Burke [:jrburke]
	Comment 8 • 10 years ago

Closing as "worksforme" since other bug tickets solved the issue.