Guilherme Gonçalves [:ggp] Reporter
	Description • 10 years ago

Steps to reproduce:

1- Open the browser app
2- Navigate to a PDF file (I can consistently reproduce this with https://crypto.stanford.edu/craig/easy-fhe.pdf , for example)
3- The file gets rendered incorrectly.

OS version
1.4.0.0-prerelease

Git commit info:
2014-01-20 07:27:55
62f5852a

	Raniere Silva
	Comment 1 • 10 years ago

This bug can also be reproduce at

OS version: 2.1.0.0-prerelese
Hardware revision: flatfish
Platform version: 33.0a1
Build Identifier: 20140618202826
Gaia Identifier: 2014-06-18 20:14:05 2526b49a

	Raniere Silva
	Comment 2 • 10 years ago

I can't reproduce this bug at hamachi:

B2G: b91a268d3415fd5eec2fab45d3072067e8c0b33d
Gecko: a16e68c38aabd1d9c86c8a6fa4e8291dbefeb59e
Gaia: 2b1524b9bd1c321d40fe0bea0e26bc2f00f74919

	Andrew Truong [:feer56] [:andrewtruong] [:atruong]
	Comment 3 • 10 years ago

Can you provide a test URL?

	Guilherme Gonçalves [:ggp] Reporter
	Comment 4 • 10 years ago

Do you mean a PDF file that reproduces the issue? I provided one in the initial report: https://crypto.stanford.edu/craig/easy-fhe.pdf

Thanks for looking into this!

	Andrew Truong [:feer56] [:andrewtruong] [:atruong]
	Comment 5 • 10 years ago

Awesome. I can also reproduce this. Maybe the pdf.js version needs to be updated for the devices.

	Benlamara
	Comment 6 • 10 years ago

the problem happens just with Pdfs with images and layers

	yifan [:yifan][:yliao] Assignee
	Comment 8 • 10 years ago

Updating pdf.js to version 1.0.524 fix the problem.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 9 • 10 years ago

Comment on attachment 8466071 [details]
pull request

I'm fine on the principle but I would prefer bdhal or yury to validate that this version works as expected and does not have some bad surprises for Gaia.

	Yury Delendik (:yury)
	Comment 10 • 10 years ago

Comment on attachment 8466071 [details]
pull request

ffos has its own viewer that is created by running `node make b2g`. the pull request replaces b2g with the standard one, which is too heavy for ffos.

	yifan [:yifan][:yliao] Assignee
	Comment 11 • 10 years ago

Comment on attachment 8466071 [details]
pull request

Thank you for the correction.
Updated the pdf.js version with 'node make b2g'.

	Yury Delendik (:yury)
	Comment 12 • 10 years ago

Comment on attachment 8466071 [details]
pull request

Looks good when CSS conflict resolved

	Yan Or
	Comment 13 • 10 years ago

Yi-Fan,

Do you mind updating to the latest pdf.js master?  It includes a patch for bug 1054590 which fixes gaia bug 1016817.

Thanks.

	yifan [:yifan][:yliao] Assignee
	Comment 14 • 10 years ago

Thanks for the suggestion. I'll update it and the pull request to be reviewed.

	yifan [:yifan][:yliao] Assignee
	Comment 15 • 10 years ago

Comment on attachment 8466071 [details]
pull request

Update pdf.js to version 1.0.700 to use the new web component based header (gaia-header)

I'm not sure if you'd like the 2 commits be squashed into one. Please feel free to advice. Thank you!

	Yury Delendik (:yury)
	Comment 16 • 10 years ago

Comment on attachment 8466071 [details]
pull request

Looks good

> I'm not sure if you'd like the 2 commits be squashed into one. Please feel
> free to advice. Thank you!

I have no preference on squashing.

	yifan [:yifan][:yliao] Assignee
	Comment 17 • 10 years ago

Merged into master
https://github.com/mozilla-b2g/gaia/pull/22397

TBPL
https://tbpl.mozilla.org/?rev=a67d38ab74f48b2b1d2330fb0517aaa1c85c52a6&tree=Gaia-Try

	yifan [:yifan][:yliao] Assignee
	Comment 18 • 10 years ago

Backout commit: 721809bad3fc5fcaf00f7b25cacccfab2ff9c499

This commit updated pdf.js to version 1.0.700 which also fixed bug 1016817. But produced bug 1056989. Reverting to 1.0.524 reopens bug 1016817. This bug is unaffected.

	Shally Li（leave from Mozilla）
	Comment 19 • 10 years ago

Per Comment 18 ("This bug is unaffected"), clear verifyme and modify status to VERIFIED FIXED.