Boris Zbarsky [:bzbarsky] Assignee
	Description • 10 years ago

To make performance.now() faster.

	Peter Van der Beken [:peterv]
	Comment 2 • 10 years ago

Comment on attachment 8430541 [details] [diff] [review]
Fix, for when we can actually land this

Review of attachment 8430541 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +2346,5 @@
>    // document.
>    mDoc = aDocument;
>    if (IsInnerWindow() && IsDOMBinding()) {
>      WindowBinding::ClearCachedDocumentValue(cx, this);
> +    WindowBinding::ClearCachedPerformanceValue(cx, this);

Might be worth extracting this to a nsGlobalWindow::ClearSlots(...)?

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 3 • 10 years ago

> Might be worth extracting this to a nsGlobalWindow::ClearSlots(...)?

How about ClearDocumentDependentSlots()?

	Peter Van der Beken [:peterv]
	Comment 4 • 10 years ago

Sure.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 10 years ago

Olli, do this bug we need to make the "performance" getter non-throwing.  That basically means backing out bug 1025078 and replacing it with the changes in this bug (to return null and null-check in console code).  Any objections?

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 6 • 10 years ago

Returning null in those very odd cases sounds ok to me.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 8 • 10 years ago

I filed bug 1063879 on making this faster on Worker too.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 10 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc2a4c5ac088

	Carsten Book [:Tomcat]
	Comment 11 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/fc2a4c5ac088