Closed Bug 1017494 Opened 10 years ago Closed 10 years ago

In-content-preferences: Hover-effect for checkboxes and radio buttons is still confusing on OS X

Categories

(Firefox :: Settings UI, defect)

x86
macOS
defect
Not set
normal
Points:
3

Tracking

()

RESOLVED DUPLICATE of bug 1008171

People

(Reporter: asaf, Unassigned)

References

Details

(Keywords: access)

Attachments

(1 file)

Attached image hover vs. focus (deleted) —
On OS X, focus rings for native checkboxes and radio buttons is drawn around the control itself, not its label. There's no native hover effect for this controls. Before bug 996036 was fixed, checkboxes and radio buttons looked as if they're focused if they were checked. That part was fixed, but the hover effect is still wrong. There's no "glowing" per-se, but I don't believe we could fix bug 1008171 properly if the border is drawn on hover. I suggest to remove the hover effect on OS X. We can keep it on Windows and Linux, because they draw focus rings around the label.
Flags: firefox-backlog+
Depends on: 996036
All that needs to be done is to %ifndef out the hover rules on OS X.
Flags: needinfo?(mmaslaney)
Michael, we could add the glow effect on :focus, what do you think?
Well, not :focus, but :-moz-focusring, right?
(In reply to Markus Stange [:mstange] from comment #3) > Well, not :focus, but :-moz-focusring, right? Correct.
Glow is subtle. I see no reason to show a blue border around the box when that indicates focus across the OS. Again, on other platforms focus is indicating by a border around the label, thus this is only an issue on OS X.
Note the missing focus feedback is covered by bug 1008171.
Summary: In-content-preferecnes: Hover-effect for checkboxes and radio buttons is still confusing on OS X → In-content-preferences: Hover-effect for checkboxes and radio buttons is still confusing on OS X
John Gruen and I are currently working on a live spec for this. More to come...
Flags: needinfo?(mmaslaney)
Michael, we need to know if this should block in-content pref shipping. Are we intentionally differing from native behaviour?
Flags: needinfo?(mmaslaney)
Matt, to the right of the linked mock you'll notice the default and active states on the left and the focus states on the right; represented by a light blue stroke (0095DD 50%) on the outside and a white stroke on the inside http://cl.ly/image/3d2k061r3M2o
Flags: needinfo?(mmaslaney)
For reference, this is how the focus state is used for our button set: http://cl.ly/image/1T3a070b3E28
(In reply to Matthew N. [:MattN] from comment #8) > Michael, we need to know if this should block in-content pref shipping. Are > we intentionally differing from native behaviour? It seems that the answer was "yes", but it was not explicit.
Points: --- → 3
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
From in-content prefs triage today, this bug was removed as a blocker for shipping in-content prefs since the checkboxes and radio buttons were designed to have a non-native look and feel. We may still be interested in a potential fix for this, but we won't block shipping the in-content prefs for this.
Blocks: 718011
No longer blocks: ship-incontent-prefs
The plan here is to bring the behavior of focused checkboxes and radio buttons on Windows to OSX. This work will be completed in bug 1008171, since at that point these bugs are pretty similar.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: