Closed Bug 1018322 Opened 10 years ago Closed 10 years ago

Checkbox "Use as default ringtone" looks bad when translation spans on multiple lines

Categories

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Ringtones
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: flod, Assigned: squib)

References

Details

Attachments

(4 files)

Screenshot Keon
(deleted), image/png
Details
Fix it
(deleted), text/x-github-pull-request
djf
: review+
tif
: ui-review+
Details
Screenshot of the fix
(deleted), image/png
Details
Fix alignment
(deleted), text/x-github-pull-request
djf
: review+
Details
Attached image Screenshot Keon (deleted) —
See attachment: horizontal alignment of the second line is off (minor), the line-height is too big.
Attached file Fix it (deleted) —
Here's a fix. (A part of me thinks I should just redo everything with flexbox, but this works and that's enough for me.)
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #8433638 - Flags: ui-review?(tshakespeare)
Attachment #8433638 - Flags: review?(dflanagan)
Attached image Screenshot of the fix (deleted) —
Comment on attachment 8433638 [details] Fix it Took a look at the screenshot and things look much better. Thanks Jim!
Attachment #8433638 - Flags: ui-review?(tshakespeare) → ui-review+
Comment on attachment 8433638 [details] Fix it looks good to me
Attachment #8433638 - Flags: review?(dflanagan) → review+
Landed: https://github.com/mozilla-b2g/gaia/pull/19962 Setting in-testsuite to "-" because this is just a CSS change.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Attached file Fix alignment (deleted) —
Whoops, I forgot to save this part of the file originally. This just makes the text centered a little nicer. I verified that this looks the same as it did before I "fixed" this bug. :)
Attachment #8433768 - Flags: review?(dflanagan)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8433768 - Flags: review?(dflanagan) → review+
Checked in: https://github.com/mozilla-b2g/gaia/commit/4fd7953bc0dd0c631814e4cc362c44fa8125ce6f
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: