Comment on attachment 8442267 [details] [diff] [review] Add telemetry for "+" button in tabs tray I'm going to make a better patch that account for private/normal tabs.

We only go through this addTab method when you hit the "+" button. I decided to make it private to make that more obvious.

Comment on attachment 8442326 [details] [diff] [review] (v2) Add telemetry for "+" button in tabs tray >diff --git a/mobile/android/base/tabspanel/TabsPanel.java b/mobile/android/base/tabspanel/TabsPanel.java >+ Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, "new_tab"); >+ Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, "new_private_tab"); Looks good. I think I'd want TelemetryContract.Method.ACTIONBAR for this one though. I know it's a button, but it appears in a row next to a 3-dot 'menu', so it tries to feel like an actionbar.

Comment on attachment 8442326 [details] [diff] [review] (v2) Add telemetry for "+" button in tabs tray [Approval Request Comment] Bug caused by (feature/regressing bug #): not a regression User impact if declined: we'll understand less about what parts of the UI users use Testing completed (on m-c, etc.): tested locally, just landed on fx-team Risk to taking this patch (and alternatives if risky): low-risk, just adds 2 telemetry probes (no user visible change) String or IDL/UUID changes made by this patch: none Note to sheriffs: I built this on top of bug 817716, so I'll need to rebase for uplift (I can do that).

Margaret, it would be nice if you could take care of the rebase. Ryan is in PTO. Thanks!

https://hg.mozilla.org/releases/mozilla-aurora/rev/c57b8688d938 https://hg.mozilla.org/releases/mozilla-beta/rev/f8b8425b4a00

Verified as fixed in builds: - 33.0a1 (2014-07-04); - 32.0a2 (2014-07-04); - 31 beta 6; Device: Samsung Galaxy Note (Android 4.1.2)