Closed
Bug 1018492
Opened 11 years ago
Closed 10 years ago
gaia-tabs should have correct accessibility roles
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Unassigned)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
While there is aria-selected - which is nice, we don't have any roles for the tabs. Also, putting in correct accessibility in the example html would be useful.
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #8431978 -
Flags: review?(kgrandon)
Comment 2•11 years ago
|
||
Comment on attachment 8431978 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843
Clearing review for now. I made one comment on github, and would like to know what you think. Thanks!
Attachment #8431978 -
Flags: review?(kgrandon)
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 8431978 [details]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843
>
> Clearing review for now. I made one comment on github, and would like to
> know what you think. Thanks!
Replied in github.
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8431978 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843
re-requesting review after answering issues in PR, and rebasing.
Attachment #8431978 -
Flags: review?(kgrandon)
Comment 6•10 years ago
|
||
Comment on attachment 8431978 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843
Redirecting review to wilson - i am currently overloaded with 2.0 stuff, sorry.
Attachment #8431978 -
Flags: review?(kgrandon) → review?(wilsonpage)
Flags: needinfo?(kgrandon)
Comment 7•10 years ago
|
||
I've ported gaia-tabs along with eejay's patch over to github.com/gaia-componets/gaia-tabs. Also added couple of tests.
No apps currently depend on this component.
Attachment #8431978 -
Attachment is obsolete: true
Attachment #8431978 -
Flags: review?(wilsonpage)
Attachment #8444529 -
Flags: review?(kgrandon)
Comment 9•10 years ago
|
||
Comment on attachment 8444529 [details]
pull-request (master)
Hey Wilson - after spending the last several weeks working on components for the verical homescreen, I had a chat with the homescreen team and feel that for now, until everything is ready, that we need to keep components internal to gaia in order to move quickly.
This does not mean that we should not continue to experiment with external components, but let's keep them internal to gaia while we solve all of our problems.
Attachment #8444529 -
Attachment is obsolete: true
Attachment #8444529 -
Flags: review?(kgrandon)
Comment 10•10 years ago
|
||
Comment on attachment 8431978 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19843
Looks fine to me, and sounds like we implemented it in the external repository approach. Let's land in gaia for now while we continue to experiment.
Attachment #8431978 -
Attachment is obsolete: false
Attachment #8431978 -
Flags: review+
Comment 11•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•