* Move WebMWriter's dtor out-of-line so the mEbmlComposer nsAutoPtr's dtor does not call delete on an incomplete type. WebMWriter.h only has a forward declaration of class EbmlComposer and can't #include "EbmlComposer.h" because that header file is not exported from the content/media/webm directory. Warning: -Wdelete-incomplete in /Users/chris/Code/mozilla/inbound/objdir-osx/dist/include/nsAutoPtr.h: deleting pointer to incomplete type 'mozilla::EbmlComposer' may cause und ../../../dist/include/nsAutoPtr.h:73:5: warning: deleting pointer to incomplete type 'mozilla::EbmlComposer' may cause undefined behavior [-Wdelete-incomplete] delete mRawPtr; ^ ~~~~~~~ ../../../dist/include/WebMWriter.h:44:7: note: in instantiation of member function 'nsAutoPtr<mozilla::EbmlComposer>::~nsAutoPtr' requested here class WebMWriter : public ContainerWriter ^ ../../../dist/include/WebMWriter.h:13:7: note: forward declaration of 'mozilla::EbmlComposer' class EbmlComposer; ^ Warning: -Wunused-variable in /Users/chris/Code/mozilla/inbound/content/media/gtest/TestWebMWriter.cpp: unused variable 'timestamp' /Users/chris/Code/mozilla/inbound/content/media/gtest/TestWebMWriter.cpp:155:12: warning: unused variable 'timestamp' [-Wunused-variable] uint64_t timestamp = 0; ^ Warning: -Wunused-variable in /Users/chris/Code/mozilla/inbound/content/media/gtest/TestWebMWriter.cpp: unused variable 'timestamp' /Users/chris/Code/mozilla/inbound/content/media/gtest/TestWebMWriter.cpp:194:12: warning: unused variable 'timestamp' [-Wunused-variable] uint64_t timestamp = 0; ^ In file included from /Users/chris/Code/mozilla/inbound/objdir-osx/content/media/gtest/Unified_cpp_content_media_gtest0.cpp:2: In file included from /Users/chris/Code/mozilla/inbound/content/media/gtest/TestAudioCompactor.cpp:7: * Here's a green try build: https://tbpl.mozilla.org/?tree=Try&rev=beff29e43938

Comment on attachment 8432059 [details] [diff] [review] fix-WebMWriter-warnings.patch Review of attachment 8432059 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the cleanup!