Closed
Bug 1018942
Opened 10 years ago
Closed 10 years ago
Collection App Testing
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: amirn, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file, 1 obsolete file)
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Kevin, can you please help up setup the testing infrastructure required for a new app?
We will take it from there :)
Blocks: collection-app
Flags: needinfo?(kgrandon)
Comment 2•10 years ago
|
||
No idea what this bug is :) but it sounds more or less like this app which I did for bookmarks [1] some weeks ago. I hope it helps, if it is noise forget my comment please :)
[1] https://github.com/mozilla-b2g/gaia/tree/master/dev_apps/bookmarks-reader
Reporter | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
I think this might be a decent place to start the testing efforts. Note: it's currently very difficult to unit test this stuff due to datastore, activities, and all of the fun things that we are using.
I might actually recommend, for the time being, that we focus on unit tests for regressions and flaky things, and try to invest some time into writing a mock server using node.js so we can leverage our integration tests.
In any case - I will definitely help you guys write some tests in the future, but just be warned that it's going to be difficult to test certain cases in the suggestions app. Please review this when you get a chance.
Attachment #8432503 -
Attachment is obsolete: true
Attachment #8432727 -
Flags: review?(ran)
Attachment #8432727 -
Flags: review?(amirn)
Flags: needinfo?(kgrandon)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8432727 [details]
Github pull request
I used the opportunity to ask general unit-test questions on GH :)
This is great. Thank you Kevin!
Attachment #8432727 -
Flags: review?(amirn) → review+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8432727 [details]
Github pull request
Ok, let's go ahead and land for now. Ran - let me know if you have any questions/concerns.
Attachment #8432727 -
Flags: review?(ran)
Assignee | ||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 8•10 years ago
|
||
Can't get 'em to execute locally for some reason.
I open http://test-agent.gaiamobile.org:8080/ on nightly and observe the output in console. All tests work fine apart for #collections. The output is "0 passing (1ms)".
Any idea what I'm doing wrong?
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 9•10 years ago
|
||
Hmm, few things possible. Let me know if neither of these things works:
1 - You might want to make a new profile folder. Sometimes it can get confused if there's a new app or whatever (though it should work if you can test collections inside of it).
2 - Try closing nightly and running the cli command: ./bin/gaia-test
You should then be able to either save the files, or run all of the collection tests with: make test-agent-test APP=collection
Flags: needinfo?(kgrandon)
Comment 10•10 years ago
|
||
Me too, the logs says to me: js files under collection/test/unit not found :(
Assignee | ||
Comment 11•10 years ago
|
||
Ran - can you check one thing real quick? Can you verify that there are no files in dev_apps/collection? If there are, please remove them and delete your profile as well. I have a feeling that they just didn't get moved due to the fact that they are not stored in git.
Let me know if that doesn't fix it for you. Thanks!
Flags: needinfo?(ran)
Comment 12•10 years ago
|
||
thanks, it works right now deleting dev_apps/collection
Assignee | ||
Comment 14•10 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•