Comment on attachment 8432565 [details] [diff] [review] patch Review of attachment 8432565 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment addressed and verification to make sure tab thumbnailing in Fennec still works. ::: widget/android/AndroidBridge.cpp @@ +1854,5 @@ > context->Translate(pt); > context->Scale(scale * bufW / srcW, scale * bufH / srcH); > rv = presShell->RenderDocument(r, renderDocFlags, bgColor, context); > if (is24bit) { > + gfxUtils::ConvertBGRAtoRGBA(buffer); I think this needs to operate on "data" rather than "buffer". Also, looking at the signature of ConvertBGRAtoRGBA, it should passing a length parameter too? (bufW * bufH probably)