Closed
Bug 1019043
Opened 10 years ago
Closed 10 years ago
Return None when getting the device manager in B2GTestCaseMixin if target is B2G desktop
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
Rather than guarding against calling get_dm or the device_manager property in B2GTestCaseMixin when the target is B2G desktop, we should just simply return None.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8432605 [details] [diff] [review] Return None for device manager on B2G desktop. v1.0 Review of attachment 8432605 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8432605 -
Flags: review?(mdas) → review+
|
Assignee | |
Comment 3•10 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=265192b6ab1d https://tbpl.mozilla.org/?tree=Try&rev=f21092705bbd
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/85db97aa8845
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/85db97aa8845
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•