Closed Bug 1019157 Opened 10 years ago Closed 10 years ago

In-content prefs: Huge Application pane with a lot of applications.

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 33

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image Huge Applications pane (deleted) —
With a lot of applications the pane becomes really tall. The pane in my Nightly has a height of 2809px. I think we should limit the height to 600px.
Michael, what do you think, should we leave it as it is or limit the listboxes height to something like 600px or less to give the possibility to see the full pane and let the listbox have the scrollbar instead of the pane. The old dialog prefs has the panes height limited and the scrollbar on the listbox.
Flags: needinfo?(mmaslaney)
Michael, would be a box height of 438px with showing 10 entries okay? When where are more than 10 then, the scrollbar appears in the listbox.
That works, thanks Richard.
Flags: needinfo?(mmaslaney)
Attached patch handlersViewHeight.patch (obsolete) (deleted) — Splinter Review
Limit the height to 10 items.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8440797 - Flags: review?(jaws)
Comment on attachment 8440797 [details] [diff] [review] handlersViewHeight.patch Review of attachment 8440797 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/shared/incontentprefs/preferences.css @@ +687,5 @@ > border-radius: 2px; > background-color: #FBFBFB; > overflow-y: auto; > + /* 10 items + listheader + border */ > + height: 438px; By default on my Win8.1 machine, I see just under 12 rows in the old preferences window. I also don't think we should try for an integer number of rows, as showing a partial row at the bottom can is a nice hint for people to see that there is more content to scroll to. r=me if you change this to height:500px;
Attachment #8440797 - Flags: review?(jaws) → review+
Attached patch Patch for check-in (deleted) — Splinter Review
Changed to 500px.
Attachment #8440797 - Attachment is obsolete: true
Attachment #8440807 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
I'm sorry for using this space to ask a question, but isn't possible to make height variable to what is visible to the user? I mean, 500px, 600px, 400px... each computer has one height. On my case now I have 2 scrollbars, one for the page and one for the applications.
(In reply to Guilherme Lima from comment #9) > On my case now I have 2 scrollbars, one for the page and one for the applications. Can you please file a new bug on this? Thanks.
Depends on: 1027652
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: