Patryk Adamczyk [:patryk] UX Reporter
	Description • 10 years ago

Looking at the settings icons @1.5x there are several issues. I can't believe we spec'd them this way. Carol can you please have a pass at them and fix any of the issues I outlined? It looks like some DO NOT use the correct forms, others just don't work as nice scaled up.

Can you work with Arnau and add them to the icon font?

	Patryk Adamczyk [:patryk] UX Reporter
	Comment 1 • 10 years ago

Is the icon font going to make it into v.2, if so can you please add the updated icons once I review them, they should done this week (I hope). Otherwise we'll get Pavel to add them as PNGs.

	Arnau March [:arnau] ( not working in Firefox OS anymore :( )
	Comment 2 • 10 years ago

A decision on how to proceed on bug 951593 is take for ever.
So I don't think icon fonts will make it for 2.0

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 3 • 10 years ago

Hey Carol,
can you provide the icons

	Carol Huang [:Carol]
	Comment 4 • 10 years ago

Hi Pavel,
I'm working on these revises. After Patryk reviewed them, I'll ship the icons ASAP! thanks

	Carol Huang [:Carol]
	Comment 5 • 10 years ago

Revise Settings icons.
--
Hi Pavel,
Could you help me updating these image for Settings, thank you.

Since the icon font will not happen in 2.0, I update the sprite first. I will soon convert the revised icon to SVG format.

	Evelyn Hung
	Comment 7 • 10 years ago

Comment on attachment 8434837 [details]
patch for Gaia/master

I can do nothing except r+ this PR, so do we need a ui-review?
I will suggest we set ui-review flag instead of review flag when you are simply updating image files. 
(maybe renaming files is not included, it still needs review).

What do you think?

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 8 • 10 years ago

Hey Evelyn,
I think that sometimes we need ui-review because of some fuzzy images ... and I think for Bugs like this one we need to have someone (like me for example) who can r+ these bugs ...

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 9 • 10 years ago

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/99286eba43659294d17c92a17a633aa3588d5c07

	Stephany Wilkes
	Comment 10 • 10 years ago

Thanks Pavel! Yes, Pavel is correct: the ui-review? flag should be used here so that we can check fuzzy images and similar before signing off for landing.