Closed Bug 1019220 Opened 11 years ago Closed 11 years ago

Settings Icons need improvements

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: padamczyk, Assigned: pivanov)

References

Details

Attachments

(3 files)

Attached image 8 Icon Issues (deleted) —
Looking at the settings icons @1.5x there are several issues. I can't believe we spec'd them this way. Carol can you please have a pass at them and fix any of the issues I outlined? It looks like some DO NOT use the correct forms, others just don't work as nice scaled up. Can you work with Arnau and add them to the icon font?
Is the icon font going to make it into v.2, if so can you please add the updated icons once I review them, they should done this week (I hope). Otherwise we'll get Pavel to add them as PNGs.
Assignee: nobody → chuang
Blocks: 1016987
Depends on: 948856
Flags: needinfo?(arnau)
A decision on how to proceed on bug 951593 is take for ever. So I don't think icon fonts will make it for 2.0
Flags: needinfo?(arnau)
Hey Carol, can you provide the icons
Hi Pavel, I'm working on these revises. After Patryk reviewed them, I'll ship the icons ASAP! thanks
Assignee: chuang → pivanov
Attached file Settings_sprite_update.zip (deleted) —
Revise Settings icons. -- Hi Pavel, Could you help me updating these image for Settings, thank you. Since the icon font will not happen in 2.0, I update the sprite first. I will soon convert the revised icon to SVG format.
Flags: needinfo?(pivanov)
Attached file patch for Gaia/master (deleted) —
Attachment #8434837 - Flags: review?(ehung)
Flags: needinfo?(pivanov)
Comment on attachment 8434837 [details] patch for Gaia/master I can do nothing except r+ this PR, so do we need a ui-review? I will suggest we set ui-review flag instead of review flag when you are simply updating image files. (maybe renaming files is not included, it still needs review). What do you think?
Attachment #8434837 - Flags: review?(ehung) → review+
Hey Evelyn, I think that sometimes we need ui-review because of some fuzzy images ... and I think for Bugs like this one we need to have someone (like me for example) who can r+ these bugs ...
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Thanks Pavel! Yes, Pavel is correct: the ui-review? flag should be used here so that we can check fuzzy images and similar before signing off for landing.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: