Closed Bug 1019372 Opened 11 years ago Closed 10 years ago

[bluetooth2] Avoid accessing static variables on different thread

Tracking

(Not tracked)

Status:

RESOLVED FIXED

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

(Whiteboard: [webbt-api])

Attachments

(6 files)

Patch 1/6 (v1): [bluetooth2] Remove unneccessary variable sIsBtEnabled to avoid racing issue 11 years ago Ben Tian (inactive) (deleted), patch	echou : review+	Details \| Diff \| Splinter Review
Patch 2/6 (v1): [bluetooth2] Dispatch part of AdapterPropertiesCallback to main thread 11 years ago Ben Tian (inactive) (deleted), patch	echou : review+	Details \| Diff \| Splinter Review
Patch 3/6 (v1): [bluetooth2] Use Atomic on certain primitive variables to ensure thread-safe 11 years ago Ben Tian (inactive) (deleted), patch	echou : review+	Details \| Diff \| Splinter Review
Patch 4/6 (v1): [bluetooth2] Dispatch part of RemoteDevicePropertiesCallback to main thread 11 years ago Ben Tian (inactive) (deleted), patch	echou : review+	Details \| Diff \| Splinter Review
Patch 5/6 (v1): [bluetooth2] Dispatch part of BondStateChangedCallback to main thread 11 years ago Ben Tian (inactive) (deleted), patch	echou : review+	Details \| Diff \| Splinter Review
Patch 6/6 (v1): [bluetooth2] Dispatch part of DiscoveryChangedCallback to main thread 11 years ago Ben Tian (inactive) (deleted), patch	echou : review+	Details \| Diff \| Splinter Review

Ben Tian (inactive)

Assignee

Description

•

11 years ago

Bug 1015826 avoids accessing static variables on different thread. The fix should be also applied on bluetooth2.

Ben Tian (inactive)

Assignee

Comment 1

•

11 years ago

Attached patch Patch 1/6 (v1): [bluetooth2] Remove unneccessary variable sIsBtEnabled to avoid racing issue (deleted) — Details — Splinter Review

Assignee: nobody → btian

Attachment #8433018 - Flags: review?(echou)

Ben Tian (inactive)

Assignee

Comment 2

•

11 years ago

Attached patch Patch 2/6 (v1): [bluetooth2] Dispatch part of AdapterPropertiesCallback to main thread (deleted) — Details — Splinter Review

Attachment #8433019 - Flags: review?(echou)

Ben Tian (inactive)

Assignee

Comment 3

•

11 years ago

Attached patch Patch 3/6 (v1): [bluetooth2] Use Atomic on certain primitive variables to ensure thread-safe (deleted) — Details — Splinter Review

Attachment #8433020 - Flags: review?(echou)

Ben Tian (inactive)

Assignee

Comment 4

•

11 years ago

Attached patch Patch 4/6 (v1): [bluetooth2] Dispatch part of RemoteDevicePropertiesCallback to main thread (deleted) — Details — Splinter Review

Attachment #8433022 - Flags: review?(echou)

Ben Tian (inactive)

Assignee

Comment 5

•

11 years ago

Attached patch Patch 5/6 (v1): [bluetooth2] Dispatch part of BondStateChangedCallback to main thread (deleted) — Details — Splinter Review

Attachment #8433023 - Flags: review?(echou)

Ben Tian (inactive)

Assignee

Comment 6

•

11 years ago

Attached patch Patch 6/6 (v1): [bluetooth2] Dispatch part of DiscoveryChangedCallback to main thread (deleted) — Details — Splinter Review

Attachment #8433026 - Flags: review?(echou)

Ben Tian (inactive)

Assignee

Updated

•

11 years ago

Whiteboard: [webbt-api]

Ben Tian (inactive)

Assignee

Updated

•

11 years ago

Blocks: 1019376

Eric Chou [:ericchou] [:echou]

Updated

•

11 years ago

Attachment #8433018 - Flags: review?(echou) → review+

Eric Chou [:ericchou] [:echou]

Updated

•

11 years ago

Attachment #8433019 - Flags: review?(echou) → review+

Eric Chou [:ericchou] [:echou]

Updated

•

11 years ago

Attachment #8433020 - Flags: review?(echou) → review+

Eric Chou [:ericchou] [:echou]

Updated

•

11 years ago

Attachment #8433022 - Flags: review?(echou) → review+

Eric Chou [:ericchou] [:echou]

Updated

•

11 years ago

Attachment #8433023 - Flags: review?(echou) → review+

Eric Chou [:ericchou] [:echou]

Comment 7

•

11 years ago

Comment on attachment 8433026 [details] [diff] [review] Patch 6/6 (v1): [bluetooth2] Dispatch part of DiscoveryChangedCallback to main thread Review of attachment 8433026 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.

Attachment #8433026 - Flags: review?(echou) → review+

Ben Tian (inactive)

Assignee

Comment 8

•

11 years ago

Set 'checkin-needed' for patch 1 ~ 6.

Keywords: checkin-needed

Ben Tian (inactive)

Assignee

Updated

•

11 years ago

Blocks: 1020300

Ryan VanderMeulen [:RyanVM]

Comment 9

•

11 years ago

Do you have a link to a recent Try push handy by chance? :)

Keywords: checkin-needed

Ben Tian (inactive)

Assignee

Comment 10

•

11 years ago

The patches don't affect tpbl result since the affected files are not built yet. They are WIP files for new bluetooth API.

Ben Tian (inactive)

Assignee

Comment 11

•

11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/d45fe00e7dcd https://hg.mozilla.org/integration/b2g-inbound/rev/76fc983a3813 https://hg.mozilla.org/integration/b2g-inbound/rev/73b2cef37ebc https://hg.mozilla.org/integration/b2g-inbound/rev/1949c7590771 https://hg.mozilla.org/integration/b2g-inbound/rev/97da7dcaf95b https://hg.mozilla.org/integration/b2g-inbound/rev/39c24d61a1b8

Carsten Book [:Tomcat]

Comment 12

•

10 years ago

https://hg.mozilla.org/mozilla-central/rev/d45fe00e7dcd https://hg.mozilla.org/mozilla-central/rev/76fc983a3813 https://hg.mozilla.org/mozilla-central/rev/73b2cef37ebc https://hg.mozilla.org/mozilla-central/rev/1949c7590771 https://hg.mozilla.org/mozilla-central/rev/97da7dcaf95b https://hg.mozilla.org/mozilla-central/rev/39c24d61a1b8

Status: NEW → RESOLVED

Closed: 10 years ago

Resolution: --- → FIXED

You need to log in before you can comment on or make changes to this bug.