Closed
Bug 1019492
Opened 10 years ago
Closed 10 years ago
Stop creating a Thebes backed gfxContext in gfxQuartzNativeDrawing
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8433234 -
Flags: review?(matt.woodrow)
|
||
Comment 1•10 years ago
|
||
gfxQuartzNativeDrawing is only used for drawing plugins and platform themes (as backgrounds), so this doesn't actually block bug 987190. It does block bug 933019 though.
|
Assignee | |
Comment 2•10 years ago
|
||
Oops, yes, I copied the wrong bug number.
|
|
Assignee | |
Comment 3•10 years ago
|
||
need to initialize mCGContext to null if we don't want the assertion in BeginNativeDrawing to fail
Attachment #8433234 -
Attachment is obsolete: true
Attachment #8433234 -
Flags: review?(matt.woodrow)
Attachment #8433298 -
Flags: review?(matt.woodrow)
|
||
Comment 4•10 years ago
|
||
If we're still using Cairo for Moz2D, will this cause a problem?
|
|
Assignee | |
Comment 5•10 years ago
|
||
No. When I wrote "Cairo" I meant a non-DrawTarget backed gfxContext.
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8433298 [details] [diff] [review]
remave cairo support
Review of attachment 8433298 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/thebes/gfxQuartzNativeDrawing.cpp
@@ +29,4 @@
>
> + if (mContext->IsCairo()) {
> + // We're past that now. Any callers that still supply a Cairo context
> + // don't deserve native theming.
Add a NS_WARNING or similar here just in case.
Attachment #8433298 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
||
Comment 8•10 years ago
|
||
Assignee: nobody → mstange
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•