Closed Bug 1019534 Opened 10 years ago Closed 10 years ago

[Collection App] Migrate data to vertical homescreen format

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Github pull request
(deleted), text/html
amirn
: review+
Details
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Depends on: 1018852
Whiteboard: [systemsfe]
Attached file Github pull request (deleted) —
10x
Attachment #8433260 - Flags: review?(amirn)
I'm sorry Crisitian, but I now realized that `apps` are called `pinned`. I will compile a home1->home2 mapping of field names later this week. changing the scope of this bug to match bug 1018852 comment 4 thanks.
Flags: needinfo?(amirn)
Blocks: collection-app
Flags: needinfo?(amirn)
Summary: [Collection App] Rename providerId to categoryId → [Collection App] Migrate data to vertical homescreen format
Flags: needinfo?(amirn)
ok, apps to pinned, right? any change more?
change (home1 -> home2): bg -> background experienceId -> categoryId apps -> pinned (TODO migrate the objects to vertical homescreen items) extraIconsData -> webicons no-change: name -> name icon -> icon defaultIcon -> defaultIcon query -> query
Flags: needinfo?(amirn)
experienceId or provider_id?
both: (only exists for user created collections) experienceId -> categoryId (only exists for pre-installed collections) provider_id -> categoryId sorry.
The homescreen had in its database (In reply to Amir Nissim (Everything.me) from comment #4) > change (home1 -> home2): > bg -> background NO > experienceId -> categoryId YES (see https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L106) > apps -> pinned (TODO migrate the objects to vertical homescreen items) YES > extraIconsData -> webicons NO > > > no-change: > name -> name YES > icon -> icon YES > defaultIcon -> defaultIcon NO > query -> query NO
and the path of icons was saved like app://homescreen.gaiamobile.org/collections/social/icon.png so should we change it to app://collection.gaiamobile.org/collections/social/icon.png right?
Added categoryId, pinned and icon with the correct path to the PR. The homescreen hadn't info about bg, extraIconsData, defaultIcon nor query. Is it in some indexedDB of evme?
Target Milestone: --- → 2.0 S3 (6june)
Done Amir, please you can review right now
Comment on attachment 8433260 [details] Github pull request added comments on GH. didn't get a chance to test on device, but don't want to block you from making progress. Thank you very much Cristian!
Attachment #8433260 - Flags: review?(amirn) → review+
Merged in master: https://github.com/mozilla-b2g/gaia/commit/c149fdc2235cbc8e800a43a30630b9559978ebe2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: