Closed
Bug 1019643
Opened 11 years ago
Closed 11 years ago
Replace exposeAll in DOM browserelement-parent code with Cu.cloneInto
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla32
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: p=1 s=it-32c-31a-30b.3 [qa-])
Attachments
(1 file)
For more net code removal and speed bonuses (over manually, recursively, looping over objects etc.)
See:
http://mxr.mozilla.org/mozilla-central/ident?i=exposeAll
|
Assignee | |
Comment 1•11 years ago
|
||
This passes all the browser-element tests for me locally, at least...
Attachment #8434093 -
Flags: review?(bobbyholley)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
Hrm, looks like the test code uses this to expose entire interfaces, with methods, which you can't cloneInto, so morphing this bug to just focus on dom/browser-element/ for now. :-(
Summary: Replace exposeAll in DOM and specialpowers mock code with Cu.cloneInto → Replace exposeAll in DOM browserelement-parent code with Cu.cloneInto
|
|
Assignee | |
Comment 3•11 years ago
|
||
Marco, can you add this to the current iteration please? Thanks!
Flags: needinfo?(mmucci)
Whiteboard: p=1 [qa-]
|
||
Comment 4•11 years ago
|
||
Added to Iteration 32.3
Flags: needinfo?(mmucci) → firefox-backlog+
Whiteboard: p=1 [qa-] → p=1 s=it-32c-31a-30b.3 [qa-]
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8434093 [details] [diff] [review]
use Cu.cloneInto for browser elements instead of manually looping through objects and exposing them,
Review of attachment 8434093 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8434093 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Whiteboard: p=1 s=it-32c-31a-30b.3 [qa-] → [fixed-in-fx-team] p=1 s=it-32c-31a-30b.3 [qa-]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team] p=1 s=it-32c-31a-30b.3 [qa-] → p=1 s=it-32c-31a-30b.3 [qa-]
Target Milestone: --- → mozilla32
|
|
||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•