Closed
Bug 1020139
Opened 11 years ago
Closed 10 years ago
Support new KeyboardEvent.code value for Sun keyboard
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
Now, code value spec defines special keys on Sun keyboard. We should support them.
|
Assignee | |
Comment 1•11 years ago
|
||
The spec bug is this: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24739
|
|
Assignee | |
Comment 2•11 years ago
|
||
Mapping table of special keys on Sun keyboard
.code value Label Android (scancode / virtual keycode) Linux (hardware keycode / keysym)
BrowserStop Stop 0x80 / KEYCODE_MEDiA_STOP 0x88 / Cancel
Again Again 0x81 / KEYCODE_UNKNOWN 0x89 / Redo
ContextMenu Props 0x82 / KEYCODE_UNKNOWN 0x8A / SunProps
Undo Undo 0x83 / KEYCODE_UNKNOWN 0x8B / Undo
Select Front 0x84 / KEYCODE_UNKNOWN 0x8C / SunFront
Copy Copy 0x85 / KEYCODE_UNKNOWN 0x8D / XF86Copy
Open Open 0x86 / KEYCODE_UNKNOWN 0x8E / XF86Open
Paste Paste 0x87 / KEYCODE_UNKNOWN 0x8F / XF86Paste
Find Find 0x88 / KEYCODE_UNKNOWN 0x90 / Find
Cut Cut 0x89 / KEYCODE_UNKNOWN 0x91 / XF86Cut
# Stop key is probably same as BrowserStop key physically. Both on Android and Linux, the sancode values are same as BrowserStop key.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Now, "Props" should be "Props". (Discussed today's meeting)
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24739#c10
|
|
Assignee | |
Comment 4•10 years ago
|
||
First, define legacy key code values defined in:
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-code.html#key-legacy
Attachment #8555844 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8555845 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8555846 -
Flags: review?(cpeterson)
|
|
Assignee | |
Comment 7•10 years ago
|
||
I.e., the patches making following mapping:
Mapping table of special keys on Sun keyboard
.code value Label Android (scancode / virtual keycode) Linux (hardware keycode / keysym)
Again Again 0x81 / KEYCODE_UNKNOWN 0x89 / Redo
Props Props 0x82 / KEYCODE_UNKNOWN 0x8A / SunProps
Undo Undo 0x83 / KEYCODE_UNKNOWN 0x8B / Undo
Select Front 0x84 / KEYCODE_UNKNOWN 0x8C / SunFront
Copy Copy 0x85 / KEYCODE_UNKNOWN 0x8D / XF86Copy
Open Open 0x86 / KEYCODE_UNKNOWN 0x8E / XF86Open
Paste Paste 0x87 / KEYCODE_UNKNOWN 0x8F / XF86Paste
Find Find 0x88 / KEYCODE_UNKNOWN 0x90 / Find
Cut Cut 0x89 / KEYCODE_UNKNOWN 0x91 / XF86Cut
|
||
Updated•10 years ago
|
Attachment #8555844 -
Flags: review?(bugs) → review+
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8555846 [details] [diff] [review]
part.3 Map special keys on Sun keyboard on Android and Gonk
Review of attachment 8555846 [details] [diff] [review]:
-----------------------------------------------------------------
Android changes LGTM, but I have not verified the scancode values. I don't have a Sun keyboard. :)
Attachment #8555846 -
Flags: review?(cpeterson) → review+
|
||
Updated•10 years ago
|
Attachment #8555845 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
|
||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0870b9735cea
https://hg.mozilla.org/mozilla-central/rev/b0cbb45a4ee7
https://hg.mozilla.org/mozilla-central/rev/67f185a86c4b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
|
Assignee | |
Comment 11•10 years ago
|
||
https://developer.mozilla.org/en-US/Firefox/Releases/38
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.code
Keywords: dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•