Closed
Bug 102021
Opened 23 years ago
Closed 23 years ago
Active Accessibility: support XUL selects (menulist)
Categories
(Core :: XUL, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: mozilla, Assigned: aaronlev)
References
Details
(Keywords: access)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
aaronlev
:
review+
hyatt
:
superreview+
|
Details | Diff | Splinter Review |
Need to hook up through XBL an implementation of nsIAccessibleProvider support
for MSAA.
Reporter | ||
Updated•23 years ago
|
Reporter | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Reporter | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Assignee | ||
Updated•23 years ago
|
Keywords: fcc508
Summary: Implement accessibility support for XUL selects (menulist and menuitems → Active Accessibility: support XUL selects (menulist)
Assignee | ||
Comment 1•23 years ago
|
||
*** Bug 109229 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 2•23 years ago
|
||
to aaron per our discussion
Assignee: jgaunt → aaronl
Status: ASSIGNED → NEW
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Whiteboard: seeking r=, sr=
Assignee | ||
Comment 4•23 years ago
|
||
Attachment #60842 -
Attachment is obsolete: true
Reporter | ||
Comment 5•23 years ago
|
||
Comment on attachment 60872 [details] [diff] [review]
Implements <menulist>, doesn't inherit from base nsSelectAccessible class, contains beginnings of <listbox> and <dropmarker> support
Change the author's names in the new file - you aren't evaughan
Index: mozilla/accessible/src/xul/nsXULSelectAccessible.cpp
+ * that are also extended by the XUL Select Accessibility support.
should be "by the HTML Select"
You have these two comments together with no class in there:
+/*
+ * A class the represents the text field in the Select to the left
+ * of the drop down button
+ */
+/**
+ * A class that represents the button inside the Select to the
+ * right of the text field
+ */
Just those little things, everything else looks fine
with these r=jgaunt
Attachment #60872 -
Flags: review+
Assignee | ||
Comment 6•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #60872 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Attachment #61326 -
Flags: review+
Comment 7•23 years ago
|
||
Comment on attachment 61326 [details] [diff] [review]
New patch with jgaunt's changes
sr=hyatt
Attachment #61326 -
Flags: superreview+
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Reporter | ||
Updated•23 years ago
|
Whiteboard: seeking r=, sr= → fix in hand, waiting for tree opening
Reporter | ||
Comment 8•23 years ago
|
||
checked in yesterday
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: fix in hand, waiting for tree opening
You need to log in
before you can comment on or make changes to this bug.
Description
•