Closed
Bug 1020460
Opened 10 years ago
Closed 10 years ago
Array.prototype.toSource should be generic
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Spoke with jorendorff about this on IRC. There's no reason for it to be non-generic, and having it be so makes this less safe for Xrays. Patch coming up.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8434295 -
Flags: review?(jorendorff)
Assignee | ||
Comment 2•10 years ago
|
||
Needed to fix a test.
Attachment #8434295 -
Attachment is obsolete: true
Attachment #8434295 -
Flags: review?(jorendorff)
Attachment #8434573 -
Flags: review?(jorendorff)
Comment 3•10 years ago
|
||
Comment on attachment 8434573 [details] [diff] [review]
Array.prototype.toSource should be generic. v2
Review of attachment 8434573 [details] [diff] [review]:
-----------------------------------------------------------------
Please throw in some trivial tests for applying this toSource method to non-array objects. (I don't care what the output is, as long as we don't crash.)
Attachment #8434573 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6502442e6133 along with bug 1021312 for apparently breaking a jsreftest: https://tbpl.mozilla.org/php/getParsedLog.php?id=41240513&tree=Mozilla-Inbound
Assignee | ||
Comment 6•10 years ago
|
||
Green try run (with some other stuff): https://tbpl.mozilla.org/?tree=Try&rev=12e2c896f82a
https://hg.mozilla.org/integration/mozilla-inbound/rev/e54cc67cf015
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment 8•10 years ago
|
||
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•