Eitan Isaacson [:eeejay] Assignee
	Description • 10 years ago

This breaks accessibility.

	Kevin Grandon :kgrandon
	Comment 2 • 10 years ago

Comment on attachment 8434462 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20033

Amazing how we could completely break accessibility =) Thanks for the patch, left a comment on github to see if we could get rid of the content tag.

	Eitan Isaacson [:eeejay] Assignee
	Comment 3 • 10 years ago

Thanks! Like I mentioned in the PR, we need the <content> tag to insert the children.

https://github.com/mozilla-b2g/gaia/commit/763b7f62805570b1606b8738075318020af3fa7d

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

Revert for Gaia unit test timeouts.
Master: https://github.com/mozilla-b2g/gaia/commit/d04b7196fb59834704ef38d400c813b7ea68d755

https://tbpl.mozilla.org/php/getParsedLog.php?id=41134833&tree=B2g-Inbound

	Kevin Grandon :kgrandon
	Comment 5 • 10 years ago

It would be good to test this on try.. I've noticed that we have an intermittent framework issue, I wonder if it could cause this test to appear to timeout?

INFO -  Xlib:  extension "RANDR" missing on display ":0".

	Eitan Isaacson [:eeejay] Assignee
	Comment 6 • 10 years ago

(In reply to Kevin Grandon :kgrandon from comment #5)
> It would be good to test this on try.. I've noticed that we have an
> intermittent framework issue, I wonder if it could cause this test to appear
> to timeout?
> 
> INFO -  Xlib:  extension "RANDR" missing on display ":0".

I don't think that should be an issue.
Running this on try again, just to isolate it:
https://tbpl.mozilla.org/?tree=Try&rev=8dbdb58a9a48

	Eitan Isaacson [:eeejay] Assignee
	Comment 7 • 10 years ago

Here is a successful run. But I suspect it didn't pull in my remote/branch..

https://tbpl.mozilla.org/?tree=Try&rev=752a12221d72

	Eitan Isaacson [:eeejay] Assignee
	Comment 8 • 10 years ago

Here is a rebased version. There seems to be general instability in our CI, but I am fairly certain that this pull request does not make tests fail.

Can I land this?

	Kevin Grandon :kgrandon
	Comment 9 • 10 years ago

Sure, let's land it. Thanks!

https://github.com/mozilla-b2g/gaia/commit/eef5b7a6f2722aa223422759b04b0e78a138ac97

	Kevin Grandon :kgrandon
	Comment 10 • 10 years ago

Comment on attachment 8438785 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20159

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 10 years ago

v2.0: https://github.com/mozilla-b2g/gaia/commit/cdd75128f7510b4dc04142a8a4bab38acd890967