We need to adjust the key alignment of keys in the bottom row, 1. The "panel switching key" ([12&] or [ABC]) should be the same size as the [Enter] key, i.e 2x normal key width. 2. Special cases for email and url keyboard, Since there will be another key '/' or '@' at the bottom row, so we should change the size to: 2a. 'Panel switching key': 1.5 x key width. 2b. [Enter] key: kept as 2x. Visual spec could be found here, attachment 8410078 [details].

It's a major issue in new feature. Nominating as 2.0 blocking. A balanced layout is really important for a large number of users.

Bruce - Can you make a product call on whether this is needed for 2.0 or not?

Going to followup offline on this.

I discussed this bug (and others like it) with Jason in IRC today. This looks like a 2.0 feature that was not correctly or fully implemented to spec, and should not ship as-is as a result (per Omega's comment #1). To that end, I am removing the blocking flag but adding the feature-b2g flag for 2.0, which it looks like this bug should have had as it was on the work list for 2.0. If this is not correct, let me know and we can discuss making it a blocking bug if it was not indeed a feature. Omega, please attach the keyboard spec that should be followed in this bug so that this can be correctly implemented. Thank you!

The visual spec is here: attachment 8410078 [details].

After the discussion with Omega and Bruce, this feature was never committed in 2.0. This is a nice to have but definitely not a critical feature as Comment 1 mentioned. Removing the feature-b2g 2.0 tag. If there's still resource after fixing 2.0 blockers, we may put someone here. Thanks.

Remove the milestone here, and we're going to tackle this after keyboard feature targeted for "2.1" is complete. Feel free to take this bug from me if anyone is interested.

I think this is ready for code review and ui review. 1. Modify _updateModifiedLayout() in layout_manager, so that it would adjust the width of panel switching key and the [Enter] key. 2. Also update the unit test for, a. use the right pattern for promise handling. b. Update the expected layout value due to change 1. Tim, please help review this. Omega, please help do ui-review for this requirement. Thanks.

Comment on attachment 8463265 [details] Patch V1 Bug on overwriting the original enter key object.

Comment on attachment 8463265 [details] Patch V1 Ask for a 2nd round review, since the patch has been updated to address the review comments. I have not updated the test yet, because I am a little confused about how to handle the case when the promise is rejected, please see my question here, https://github.com/mozilla-b2g/gaia/pull/22204#discussion_r15456137 Thanks.

Comment on attachment 8463265 [details] Patch V1 Thanks for the pointer, I have posted the correction on Github.

Comment on attachment 8463265 [details] Patch V1 Hi Rudy, As our offline discussion,when PinYin keyboard is in Single IME, the bottom row width should be the same sizes as in English keyboard. Please adjust the layout, thank you :)

Comment on attachment 8463265 [details] Patch V1 Patch updated to address the UI review, please refer to https://github.com/RudyLu/gaia/commit/38da822d9acd04970bcb4317472912fa34f43857 -- And this commit to update the tests to follow the correct pattern around promise. https://github.com/RudyLu/gaia/commit/4002c2cf425f399c888275f2faf7bfdcc2b32d55 Tim, Since the patch has been updated to some extent, so I'll ask for your help to review it again. Thanks.

Comment on attachment 8463265 [details] Patch V1 Thank you for completing additional test cases.

Comment on attachment 8463265 [details] Patch V1 Looks good from UX side.

Comment on attachment 8463265 [details] Patch V1 Hi Rudy, I saw the adjustment, thank you!!

Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/1dd9769ebfc90ce02dca843dedd3e8a173a0454c -- The CI result is good on TBPL. https://tbpl.mozilla.org/?rev=d769842a3b83ceb6a9ff3d88c4e730f04ce54dc6&tree=Gaia-Try Tim, Omega, Carol, Thanks for the review.

This caused an regression that pinyin layout would not show its own alternative layout, so I'll just back out this patch and re-land it after I fixed the above issue. Thanks to Tim for finding out this regression. -- revert commit: 6da3835996c68794a5a81b7d7f9713644ff4b4c7

Relanded to Gaia master, https://github.com/mozilla-b2g/gaia/commit/4a2cf78d89c31c903cea3510907e6c50696a5c39

This issue has been verified successfully on Flame 2.1. See attachment: Verify_1020779_1.png & Verify_1020779_2.png Reproducing rate: 0/10 Flame v2.1 version: Gaia-Rev 5655269098c7e82254e56933f1af05b4abe2a2f3 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5 Build-ID 20141204001201 Version 34.0