Closed
Bug 102088
Opened 23 years ago
Closed 23 years ago
Cleanup of transitory font APIs
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: rbs, Assigned: rbs)
Details
Attachments
(1 file)
(deleted),
patch
|
waterson
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
Now that bug 99010 is fixed, transitory font APIs need to be cleaned up. Vallers
should be moved to GetTextDimensions(). Nobody likes the name DrawString2()...
it should be renamed and take over from the old DrawString() which is going
away.
A canditate name of DrawString2() could be DrawText() to help clear the old
semantics attached to the old DrawString(). Also, DrawText() matches nicer with
GetTextDimensions(). However there are several helper DrawString() methods,
and I wonder if it is worth the launching of a s///g on these helpers too. Hence
it is also tempting to stay with the old name DrawString(). To do or not to do.
Let the quibbling begins.
Comment 2•23 years ago
|
||
Does DrawString2/DrawText pass in a y coordinate at the baseline?
If so, will this work smoothly with baseline adjust values from the BASE table?
http://www.microsoft.com/typography/tt/win95tt.htm
The BASE table contains baseline and minimum/maximum extent data for
each script. Script baselines can be defined in relation to one another
to properly align glyphs from different scripts.
Comment 3•23 years ago
|
||
adding yokoyama and nhotta to the cc: list as they may have interest in
font API changes
>Does DrawString2/DrawText pass in a y coordinate at the baseline?
Yes.
>If so, will this work smoothly with baseline adjust values from the BASE table?
Yes since it is the GDI that is doing the drawing in TA_BASELINE mode.
In fact, GfxWin used not to draw at the baseline, but when the support for
MathML/Symbol fonts where hooked in, misalignements were experienced during
font-switching, and we had to switch to the baseline mode. Since then, no case
of misalignments have been observed.
Ready for r/sr
Back to DrawString(). I tried DrawText() and had troubles with it because the
same name is used by the Windows GDI and caused it to be confused. I had to
re-cleanup :-(
Comment 7•23 years ago
|
||
Comment on attachment 55710 [details] [diff] [review]
cleanup patch
sr=attinasi
Attachment #55710 -
Flags: superreview+
Comment 8•23 years ago
|
||
Comment on attachment 55710 [details] [diff] [review]
cleanup patch
r=waterson
Attachment #55710 -
Flags: review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•