Closed Bug 1020914 Opened 10 years ago Closed 10 years ago

[FTU]Missing images

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: HHuang, Unassigned)

References

Details

Attachments

(2 files)

Base on Pavel's feedback, there's some missing images that need to update, and revise some images.
Blocks: 1016987
Attached file FTU missing images.zip (deleted) —
Hi Pavel, could you help to update those images? thank you!
Flags: needinfo?(pivanov)
Attached file patch for Gaia/master (deleted) —
Hey Helen,
can you check cheerfully this one (we have a lot of changes)
Attachment #8434924 - Flags: ui-review?(hhuang)
Flags: needinfo?(pivanov)
Comment on attachment 8434924 [details]
patch for Gaia/master

Thanks!
Attachment #8434924 - Flags: ui-review?(hhuang) → ui-review+
Attachment #8434924 - Flags: review?(francisco)
Comment on attachment 8434924 [details]
patch for Gaia/master

We are adding the FTU-Wifi.zip file to the repo and it's not needed :)

Also, another question Pavel, are the images gone through the tool:
./tools/png_recompress.sh

to reduce the image size without altering the quality?
Attachment #8434924 - Flags: review?(francisco) → review-
Yep I run all images with `./tools/png_recompress.sh`
So Francisco,
can we mark this as resolved/fixed? or I need to do something else first?
(In reply to Pavel Ivanov [:ivanovpavel] from comment #6)
> So Francisco,
> can we mark this as resolved/fixed? or I need to do something else first?

Hi Pavel, sorry didn't notice your email, you should try to flag for r? again.

Anyway, did you remove the FTU-Wifi.zip file from your PR? We don't need that file in the repo.
Comment on attachment 8434924 [details]
patch for Gaia/master

oh :) sure I removed it
Attachment #8434924 - Flags: review- → review?(francisco)
Comment on attachment 8434924 [details]
patch for Gaia/master

Perfect!

Please merge once you have a green travis
Attachment #8434924 - Flags: review?(francisco) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/9a7d11230e7868611b81d008da95151880b440f0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: