Closed
Bug 1020914
Opened 10 years ago
Closed 10 years ago
[FTU]Missing images
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Firefox OS Graveyard
Gaia::First Time Experience
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: HHuang, Unassigned)
References
Details
Attachments
(2 files)
(deleted),
application/zip
|
Details | |
(deleted),
text/x-github-pull-request
|
arcturus
:
review+
HHuang
:
ui-review+
|
Details |
Base on Pavel's feedback, there's some missing images that need to update, and revise some images.
Reporter | ||
Comment 1•10 years ago
|
||
Hi Pavel, could you help to update those images? thank you!
Flags: needinfo?(pivanov)
Comment 2•10 years ago
|
||
Hey Helen, can you check cheerfully this one (we have a lot of changes)
Attachment #8434924 -
Flags: ui-review?(hhuang)
Flags: needinfo?(pivanov)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8434924 [details]
patch for Gaia/master
Thanks!
Attachment #8434924 -
Flags: ui-review?(hhuang) → ui-review+
Updated•10 years ago
|
Attachment #8434924 -
Flags: review?(francisco)
Comment 4•10 years ago
|
||
Comment on attachment 8434924 [details]
patch for Gaia/master
We are adding the FTU-Wifi.zip file to the repo and it's not needed :)
Also, another question Pavel, are the images gone through the tool:
./tools/png_recompress.sh
to reduce the image size without altering the quality?
Attachment #8434924 -
Flags: review?(francisco) → review-
Comment 5•10 years ago
|
||
Yep I run all images with `./tools/png_recompress.sh`
Comment 6•10 years ago
|
||
So Francisco, can we mark this as resolved/fixed? or I need to do something else first?
Comment 7•10 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #6) > So Francisco, > can we mark this as resolved/fixed? or I need to do something else first? Hi Pavel, sorry didn't notice your email, you should try to flag for r? again. Anyway, did you remove the FTU-Wifi.zip file from your PR? We don't need that file in the repo.
Comment 8•10 years ago
|
||
Comment on attachment 8434924 [details]
patch for Gaia/master
oh :) sure I removed it
Attachment #8434924 -
Flags: review- → review?(francisco)
Comment 9•10 years ago
|
||
Comment on attachment 8434924 [details]
patch for Gaia/master
Perfect!
Please merge once you have a green travis
Attachment #8434924 -
Flags: review?(francisco) → review+
Comment 10•10 years ago
|
||
Thanks :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/9a7d11230e7868611b81d008da95151880b440f0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•