Closed Bug 1020927 Opened 10 years ago Closed 10 years ago

Update OTS to bf4afceb8b441f3a219dd7cfea5613c18183836c or later

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: fredw, Assigned: fredw)

References

Details

Attachments

(3 files, 2 obsolete files)

Part 1 - Update OTS to 06372729b075619ec94aa2e075afcabc894b6069 so that WOFF2 can be disabled at build time
(deleted), patch
jfkthame
: review+
Details | Diff | Splinter Review
Part 2 - Update OTS to bf4afceb8b441f3a219dd7cfea5613c18183836c so that we fix the compile warnings and can simplify ots-visibility.patch
(deleted), patch
jfkthame
: review+
Details | Diff | Splinter Review
Part 3 - Update OTS to d6018b62bf41f6b419aeae6d2795725a55715481 to accept 0 lookup for lookup, feature or script offset.
(deleted), patch
jfkthame
: review+
Details | Diff | Splinter Review
No description provided.
Blocks: 968139
This excludes the change of 9f5b6e2e6a5c0182e4c89233aff8a4f6414d55e0 that was causing a crash. It was fixed in a later commit.
The patches compile for me locally. Let's see if they are not causing any other troubles: https://tbpl.mozilla.org/?tree=Try&rev=6a86a19fa5f7
So as I see the other changes after bf4afceb8b441f3a219dd7cfea5613c18183836c apply to doc/tests (that we don't include in Gecko) and to the WOFF2 implementation (that is currently disabled) and otherwise are: https://github.com/khaledhosny/ots/commit/945fbeb6068010d48c180d4383f8390c54087af5 (Remove unused kShortFlagsContinue) https://github.com/khaledhosny/ots/commit/d6018b62bf41f6b419aeae6d2795725a55715481 (accept 0 lookup, feature or script offset) Do we need another patch to include any of these commits or anything important that I missed?
Assignee: nobody → fred.wang
Attachment #8434923 - Attachment is obsolete: true
Attachment #8434925 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8435119 - Attachment description: Update OTS to 06372729b075619ec94aa2e075afcabc894b6069 so that WOFF2 can be disabled at build time → Part 1 - Update OTS to 06372729b075619ec94aa2e075afcabc894b6069 so that WOFF2 can be disabled at build time
Attachment #8435122 - Attachment description: Update OTS to d6018b62bf41f6b419aeae6d2795725a55715481 to accept 0 lookup for lookup, feature or script offset. → Part 3 - Update OTS to d6018b62bf41f6b419aeae6d2795725a55715481 to accept 0 lookup for lookup, feature or script offset.
So I think we can update to d6018b62bf41f6b419aeae6d2795725a55715481. The following commits are for WOFF2 and the OTS build system.
Attachment #8435119 - Flags: review?(jfkthame)
Attachment #8435121 - Flags: review?(jfkthame)
Attachment #8435122 - Flags: review?(jfkthame)
Attachment #8435119 - Flags: review?(jfkthame) → review+
Attachment #8435121 - Flags: review?(jfkthame) → review+
Attachment #8435122 - Flags: review?(jfkthame) → review+
Blocks: 1057488
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: