Closed
Bug 1020975
Opened 10 years ago
Closed 5 years ago
No WebIDL overload allowed when extended attributes differ
Categories
(Core :: DOM: Core & HTML, defect, P5)
Tracking
()
RESOLVED
FIXED
mozilla70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: milan, Assigned: saschanaz)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Can't do something like this:
interface CanvasPattern {
[Throws, LenientFloat]
void setTransform(double a, double b, double c, double d, double e, double f);
[Throws]
void setTransform(SVGMatrix matrix);
};
the error is:
Extended attributes differ on different overloads of <unresolved scope>::setTransform...
Ehsan suggested this is a bug, so here we go.
Comment 1•10 years ago
|
||
This probably is We have no particular plans to change this behavior at this time. It would require storing separate extended attribute sets for each signature of the overload set, and many extended attributes don't make sense on a per-overload basis.
In this case, you can simply put LenientFloat on the second overload, of course.
Comment 2•10 years ago
|
||
Er, ignore the "This probably is" bit above.
Reporter | ||
Comment 3•10 years ago
|
||
Yes, not really blocking any work. On a side note, can't actually put LenientFloat on the second override, we get a different error :)
Comment 4•10 years ago
|
||
> we get a different error
Er... which one?
Comment 5•10 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #4)
> > we get a different error
>
> Er... which one?
"[LenientFloat] used on an operation with no restricted float type arguments" from WebIDL.py.
Comment 6•10 years ago
|
||
> "[LenientFloat] used on an operation with no restricted float type arguments"
Ah. We should relax that for the overload case, I guess, and either do that check once we have all the overloads or allow [LenientFloat] to be specified on some overloads but not others and make sure it ends up on the operation if it's on any of the overloads.
Comment 7•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046
Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.
If you have questions, please contact :mdaly.
Priority: -- → P5
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Assignee | ||
Comment 8•5 years ago
|
||
This assumes that LenientFloat won't break float-less overload behavior.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5161e20b698e
Allow LenientFloat to be only in a specific overload r=bzbarsky
Comment 10•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Updated•5 years ago
|
Assignee: nobody → saschanaz
You need to log in
before you can comment on or make changes to this bug.
Description
•