Closed
Bug 1021110
Opened 10 years ago
Closed 10 years ago
Icons in about:newtab's search panel should be high-res (2x DPI) on high-res displays
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 33
Tracking | Status | |
---|---|---|
firefox33 | --- | verified |
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: p=2 s=33.1 [qa!])
Attachments
(1 file)
(deleted),
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
On my high-res MacBook, the icons in about:newtab's search panel are fuzzy. They should be 2x DPI or whatever the right term is, like how they are in the standard search bar in the browser's toolbar. The search bar is drawing from the same data that about:newtab is, so I'm not sure what needs to happen. Matt mentioned that icons in browser tabs are chosen using -moz-resolution, so maybe that's the way to do it.
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
That was incredibly easy. #-moz-resolution is magic. This is based on how the search bar's icons are defined: http://mxr.mozilla.org/mozilla-central/source/browser/components/search/content/search.xml?rev=1061661a1119#296 Tab icons work the same way: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml?rev=20f9b816ebcd#834
newtab's larger search logos should probably work the same way.
Assignee | ||
Comment 2•10 years ago
|
||
Marco, could we add this to the current iteration, please?
Re-evaluating at p=2 since this hasn't been prioritized yet. A little larger than a 1 since it took some time to figure out, but smaller than a 3 because the implementation was so simple.
Flags: needinfo?(mmucci)
Whiteboard: p=3 → p=2
Comment 3•10 years ago
|
||
Added to Iteration 33.1
Would you recommend a [qa+] or [qa-] for verification?
Flags: needinfo?(mmucci)
Whiteboard: p=2 → p=2 s=33.1 [qa?]
Assignee | ||
Updated•10 years ago
|
Whiteboard: p=2 s=33.1 [qa?] → p=2 s=33.1 [qa+]
Comment 4•10 years ago
|
||
Comment on attachment 8441692 [details] [diff] [review]
patch
Review of attachment 8441692 [details] [diff] [review]:
-----------------------------------------------------------------
Fancy. Did you verify that this works with object URLs?
Attachment #8441692 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks for the quick review. Yes, it looks great, much better than before.
https://hg.mozilla.org/integration/fx-team/rev/ee97689a0506
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Comment 7•10 years ago
|
||
Hi Florin, can a contact be assigned for QA verification.
Flags: needinfo?(florin.mezei)
Comment 8•10 years ago
|
||
Juan, could you verify this on your side since we do not have a Retina device here?
Flags: needinfo?(florin.mezei) → needinfo?(jbecerra)
QA Contact: jbecerra
Comment 9•10 years ago
|
||
Verified in latest nightly using a MB with Retina display running 10.9.x. Icons in the about:newtab page look sharp.
status-firefox33:
--- → verified
Flags: needinfo?(jbecerra)
Whiteboard: p=2 s=33.1 [qa+] → p=2 s=33.1 [qa!]
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•