Closed Bug 1021391 Opened 10 years ago Closed 10 years ago

[VsD Refresh] Lockscreen Visual Refresh > Unlock icon too low

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-, b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: pla, Assigned: mnjul)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform][2.0-FL-bug-bash] [p=1])

Attachments

(5 files)

LockIconTooLow.jpg
(deleted), image/jpeg
Details
lock_screen_original.png
(deleted), image/png
Details
lock_screen_up2px_0.1rem.png
(deleted), image/png
pla
: ui-review-
Details
lock_screen_up3px_0.2rem.png
(deleted), image/png
Details
Patch
(deleted), text/x-github-pull-request
gweng
: review+
bajaj
: approval-gaia-v2.0+
Details
Attached image LockIconTooLow.jpg (deleted) — 
The unlock icon in the lockscreen looks too low visually.  It needs to be moved up 3 pixels to appear visually centered.  See attachment.
Assignee: nobody → jlu
Status: NEW → ASSIGNED
Whiteboard: ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform] → ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform][2.0-FL-bug-bash]
Attached image lock_screen_original.png (deleted) — 

    
    

    
  

      
      
      
      

        Attached image
          
        lock_screen_up2px_0.1rem.png (deleted)
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached image
          
        lock_screen_up3px_0.2rem.png (deleted)
        — 
      

    


  

    
    

    
  
Comment on attachment 8435506 [details]
lock_screen_up2px_0.1rem.png

Hi Peter,

I did some CSS manipulation and it appeared that upping 2px (0.1rem) seems to be visually better than upping 3px (0.2rem). Please see my attachments. So I'd like to confirm if you want to go with 2px or 3px? Thanks :)

        Attachment #8435506 -
        Flags: ui-review?(pla)
Whiteboard: ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform][2.0-FL-bug-bash] → ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform][2.0-FL-bug-bash] [p=1]
Target Milestone: --- → 2.0 S4 (20june)

    
    

    
  
Comment on attachment 8435506 [details]
lock_screen_up2px_0.1rem.png

Hi John,

Appreciate your input, but I think I like the original ask to move it up 3 pixels better.

        Attachment #8435506 -
        Flags: ui-review?(pla) → ui-review-

    
    

    
  

      
      
      
      

        Attached file
          
        Patch (deleted)
        — 
      

    


  

        Attachment #8436644 -
        Flags: review?(gweng)
blocking-b2g: --- → 2.0?

    
    

    
  
Feel free to seek uplift when ready but this is not a blocker for release.
blocking-b2g: 2.0? → -

    
    

    
  
Comment on attachment 8436644 [details]
Patch

Style changes, and tests passed. Go ahead and thanks for your help.

        Attachment #8436644 -
        Flags: review?(gweng) → review+

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/7ffd675e39e3e22283ed388b3faecdc3f0417962
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8436644 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): bug 1021391 was because of not-to-spec implementation of bug 950884

[User impact] if declined: minimal, as this is only cosmetic change

[Testing completed]: Yes, both Travis and TBPL, with rebase against master just 1.5 hours ago

[Risk to taking this patch] (and alternatives if risky): minimal, as this is only cosmetic change

[String changes made]: None

        Attachment #8436644 -
        Flags: approval-gaia-v2.0?

        Attachment #8436644 -
        Flags: approval-gaia-v2.0? → approval-gaia-v2.0+

    
  
Blocks: 1020115

    
    

    
  
How is this approval+ with ui-review-? Please clarify.

    
    

    
  
(In reply to Stephany Wilkes from comment #12)
> How is this approval+ with ui-review-? Please clarify.

I assumed JOhn's patch addressed the UX comment and since it had landed on master with no further comments from anyone. If the patches are not ready, they should not be requesting approval.

    
    

    
  
Peter, can you verify whether ui-review is - or + here? Thank you!
Flags: needinfo?(pla)

    
    

    
  
Hi there,
the 3px upping was made into CSS in the patch and it looked like exactly in one of my screenshots.

    
    

    
  
Hi Stephany/John,

I tried building your branch but I got an error.  Can you just post a screenshot?

Thanks,
Peter.
Flags: needinfo?(pla)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: