According to bug 984274 comment #228, deadlock happened frequently while opening/closing camera HAL repetitively during the emulator mochitest.

@ayang, could you provide what you've found while investigating bug 984274? People can continue hunting the root case based on your work.

A deadlock at EmulatedCameraDevice::WorkerThread::stopThread() in android camera emulator HAL EmulatedCameraDevice.cpp.

I think it is not a dup, I still saw the deadlock log after bug 1022705 landed. https://tbpl.mozilla.org/php/getParsedLog.php?id=42028723&full=1&branch=b2g-inbound

It also blocks other tests like ImageCapture test in bug 1069222.

Fix emulated camera start/stop deadlock problem on try tests which open emulated camera preview. Try result. https://tbpl.mozilla.org/?tree=Try&rev=a3d17a2044f3

Release on try looks good. Failures on debug are probably due to taking too long. 00:47:16 INFO - 14 INFO TEST-OK | /tests/b2g/components/test/mochitest/test_permission_gum_remember.html | took 52499ms

Comment on attachment 8495738 [details] Wait for worker thread starting in startThread. This looks good to me.

Hi schien, I try to fix the camera hal deadlock problem. There are 2 timeouts in try release test_permission_gum_remember.html. Do you think they are camera deadlock problem or other issue? https://tbpl.mozilla.org/?tree=Try&rev=a3d17a2044f3

Comment on attachment 8495741 [details] [diff] [review] use camera hal fix and enable gum test Review of attachment 8495741 [details] [diff] [review]: ----------------------------------------------------------------- My guess is there are some more issue in the gum test cases. I'll suggest no to turn on these test cases until we fix it. ::: b2g/config/emulator/sources.xml @@ +6,5 @@ > <!--original fetch url was https://git.mozilla.org/b2g--> > <remote fetch="https://git.mozilla.org/b2g" name="b2gmozilla"/> > <!--original fetch url was git://github.com/mozilla-b2g/--> > <remote fetch="https://git.mozilla.org/b2g" name="b2g"/> > + <remote fetch="https://github.com/alfredoyang" name="alfredo"/> Why not commit your change directly to https://github.com/mozilla-b2g/android-development?

Comment on attachment 8495741 [details] [diff] [review] use camera hal fix and enable gum test Review of attachment 8495741 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/config/emulator/sources.xml @@ +6,5 @@ > <!--original fetch url was https://git.mozilla.org/b2g--> > <remote fetch="https://git.mozilla.org/b2g" name="b2gmozilla"/> > <!--original fetch url was git://github.com/mozilla-b2g/--> > <remote fetch="https://git.mozilla.org/b2g" name="b2g"/> > + <remote fetch="https://github.com/alfredoyang" name="alfredo"/> Ya, that's what I want to do next. :)

Hi sheriff, please help to commit the pull-request. Thanks.

emu-fix: https://github.com/mozilla-b2g/android-development/commit/c99e41d49f0b98eade30814e52c1de9e818def68

The result looks to open/close camera rapidly. https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c