Closed Bug 1021831 Opened 10 years ago Closed 10 years ago

Project Editor: show "Validation status" tooltip over the status circle in app manager header

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: bgrins, Assigned: janx)

References

Details

Attachments

(2 files)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1019676#c5 Hovering the bullet should show a tooltip: "Validation status: ..."
OS: Mac OS X → All
Hardware: x86 → All
There is a property called 'validationStatus' that gets passed into the project editor from webide.js [0]. Here is where it is documented [1], implemented [2], and tested [3] within the project editor. This case involves a new string field (maybe named 'validationTooltip') for setting the tooltip on that circle, and it will more or less be a copy of that validationStatus property. [0]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/webide/content/webide.js#414 [1]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/lib/projecteditor.js#359 [2]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/lib/plugins/app-manager/plugin.js#61 [3]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/test/browser_projecteditor_app_options.js#47
And it is easier for developing to work at this URL: chrome://browser/content/devtools/projecteditor-loader.xul, and modify devtools/projecteditor/chrome/content/projecteditor-loader.js's call to setProjectToAppPath to add the new option. This workflow is better for me at least than opening the WebIDE constantly while making projecteditor changes. Plus you can use the normal toolbox on the page.
Jan, do you think you could take this one? We're hoping to enable WebIDE for 34, so there's only a few weeks left. Let me know if you don't have time.
Flags: needinfo?(janx)
On it.
Assignee: nobody → janx
Status: NEW → ASSIGNED
Flags: needinfo?(janx)
Attached image screenshot (invisible mouse pointer) (deleted) —
Attachment #8471591 - Flags: review?(paul)
Attachment #8471592 - Attachment description: screenshot → screenshot (invisible mouse pointer)
Attachment #8471591 - Flags: review?(paul) → review+
Note: I used WebIDE's localization and not Itchpad/Project Editor's localization. My thinking was that the project validation status has more to do with the IDE than the editor, but it causes some Project Editor strings to be in "webide.properties" instead of "projecteditor.properties". If that's ok, can you please land this patch? I'll get around to requesting level 3 soon so that I can stop bothering you :)
Flags: needinfo?(paul)
webide's localization in the app-manager plugin. So that's ok.
Flags: needinfo?(paul)
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [good first verify]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: