Closed
Bug 1021946
Opened 10 years ago
Closed 10 years ago
Transition away from using entity.textContent in Email L10n
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
In bug 994290, we're trying to transition away from treating entity attributes as node properties.
One of the blockers is an entity in Email app https://github.com/mozilla-b2g/gaia/blob/4c68a009c976cee54f63a09d7b512f99e49ef399/apps/email/locales/email.en-US.properties#L305
message-attachment-view.textContent=View
Since we localize entity value into node textContent, we should be just able to switch to
message-attachment-view=View
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Andrew, you're the author of the origin patch. can you take a look at this?
Attachment #8436075 -
Flags: review?(bugmail)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8436075 [details]
patch
Huh, so I have no idea why I put .textContent on there. Must have been a brain glitch that just happened to work out...
Attachment #8436075 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Commit: https://github.com/mozilla-b2g/gaia/commit/9a909af01d8402804c485c7c59c0c7dd6b762178
Merge: https://github.com/mozilla-b2g/gaia/commit/bd623298ba78d27a82fba438bb8b37e99b62e028
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•