Comment on attachment 8436305 [details] [diff] [review] v1 Review of attachment 8436305 [details] [diff] [review]: ----------------------------------------------------------------- Fortunately for you, I couldn't go back to sleep after waking up this morning, so I actually have a small window of time to actually review this. This does make both the probably-cache-related failing tests pass, which I assume is a decent enough proxy to gauge which cache is being used. ::: mail/app/profile/all-thunderbird.js @@ +868,5 @@ > // If set to true, when saving a message to a file, use underscore > // instead of space in the file name. > pref("mail.save_msg_filename_underscores_for_space", false); > + > +// Disable cache v2 since migration has not been done Can you note here the bug where the migration in c-c will be done? I suppose that's bug 1021843 at this point...

(In reply to Joshua Cranmer [:jcranmer] (away June 7-12) from comment #2) > Comment on attachment 8436305 [details] [diff] [review] > v1 > > Review of attachment 8436305 [details] [diff] [review]: > ----------------------------------------------------------------- > > Fortunately for you, I couldn't go back to sleep after waking up this > morning, so I actually have a small window of time to actually review this. I had today something very similar! What a coincidence.. I'll update and land. Thanks!

Here is a try push https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=865b93680d14 Will land when green enough.

Seems OK to me, at least nothing visibly cache related. When I get approval for c-c landing, I will push it.

Can someone land this please for me? Thanks.