Closed
Bug 1022205
Opened 10 years ago
Closed 10 years ago
Should not use egl fence sync on hamachi
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #999694 +++
Bug 999694 add EGL fence support to SharedSurface_Gralloc. But we can not use this in ICS devices like hamachi. It can not do correct syncing.
WebGL rendeirng tearing could be observed by the following STR.
- [1] start crystalskull
- [2] touch screen and keep the skull rotating
This problem was already mentioned in Bug 843599 Comment 15 :-(
Assignee | ||
Comment 1•10 years ago
|
||
Nominate to b2g-v1.4 It is a serious regression for ICS devices.
blocking-b2g: --- → 1.4?
Assignee | ||
Comment 2•10 years ago
|
||
During [2] the problem seems more difficult to reproduce than before. It might be an effect from Bug 1006957.
Just after start up the crystalskull app, the problem seems easier to observe.
Updated•10 years ago
|
blocking-b2g: 1.4? → backlog
Comment 3•10 years ago
|
||
Is this applicable to KK or JB devices?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #3)
> Is this applicable to KK or JB devices?
This problem happens only on qcom ICS device.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 5•10 years ago
|
||
Confirmed the patch works on hamachi.
Assignee | ||
Updated•10 years ago
|
Attachment #8443937 -
Flags: review?(jgilbert)
Comment 6•10 years ago
|
||
Comment on attachment 8443937 [details] [diff] [review]
patch - disable sync fence on AdrenoTM200
Review of attachment 8443937 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/SharedSurfaceGralloc.cpp
@@ +179,5 @@
> // When Android native fences are available, try
> // them first since they're more likely to work.
> // Android native fences are also likely to perform better.
> + if (!disableSyncFence &&
> + mEGL->IsExtensionSupported(GLLibraryEGL::ANDROID_native_fence_sync)) {
Drop { to next line for multi-line conditionals.
@@ +204,5 @@
> }
> }
>
> + if (!disableSyncFence &&
> + mEGL->IsExtensionSupported(GLLibraryEGL::KHR_fence_sync)) {
Drop { to next line for multi-line conditionals.
Attachment #8443937 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•