Hung Nguyen Reporter
	Description • 10 years ago

Updating the notification tray to a flat design to match the visual design language of 2.0. 

Please see specification for further details. 

Thanks

	Jason Smith [:jsmith]
	Comment 1 • 10 years ago

This is unrelated to the vertical homescreen.

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 2 • 10 years ago

Taking if nobody else is already working on it. :)

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 3 • 10 years ago

Pretty done, however I'm seeing other UI gradients that aren't covered in the spec..

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 4 • 10 years ago

Comment on attachment 8443579 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20812

r=me

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 5 • 10 years ago

Umm.. Alive can you please merge for me if all is well? I don't have write access, I'm just a contributor. :)

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 6 • 10 years ago

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #5)
> Umm.. Alive can you please merge for me if all is well? I don't have write
> access, I'm just a contributor. :)

Could you flag ui review to Peter La? And if everything is ok, put 'checkin-needed' in keywords then someone will merge for you!

	Peter La
	Comment 8 • 10 years ago

Comment on attachment 8444144 [details]
Screenshot - After Patch

Hi Ahmed,

Thanks for contributing!  This is looking great.  There is just one small detail you missed.  There is a thin vertical line on the left side (next the where it says 2.41 MB).  If you can get rid of that line so that it is flat grey throughout, that would make it perfect.

See my next comment for attachment showing exactly where.

Thanks!
Peter

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 10 • 10 years ago

Comment on attachment 8443579 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20812

Patch updated, asking for r? to make sure everything's fine and I haven't forgot anything. :)
Will be attaching screenshot for ui-review

Thanks

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 11 • 10 years ago

Issue addressed.

	Peter La
	Comment 12 • 10 years ago

Comment on attachment 8444533 [details]
2014-06-23-18-17-33.png

Lookin' good!  Thanks Ahmed!

	Kevin Grandon :kgrandon
	Comment 13 • 10 years ago

Landed: https://github.com/mozilla-b2g/gaia/commit/f10cd69665c2570e55a8b56546a5ae374d01eea9

Also blocking homescreen to keep track of necessary uplifts.

	Kevin Grandon :kgrandon
	Comment 14 • 10 years ago

Comment on attachment 8443579 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20812

This is a low risk visual polish patch which UX would like to have for the vertical homescreen.

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 10 years ago

v2.0: https://github.com/mozilla-b2g/gaia/commit/979dd44acfbf89f2bb8b5361445ee3fd58c67a78