Closed
Bug 1022450
Opened 10 years ago
Closed 10 years ago
[Flame][V1.4][Dialer]The key press tone will distort when you tap the number key during the call.
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: panda67231, Assigned: gsvelto)
References
Details
(Whiteboard: bamboo)
Attachments
(5 files)
[1.Description]:
The key press tone will distort when you tap the number key during the call. It will make user feel uncomfortable.
Attach the video: video_tone.mp4
Attach the logs: logcat_tone.txt & bugreport_tone.txt
Happened time: 11:54AM
[2.Testing Steps]:
1. Make a call to 10086
2. Innvoke the keypad during the call
3. Tap the number key during the call
[3.Expected Result]:
3. The key press tone should not distort.
[4.Actual Result]:
3. The key press tone will distort.
[5.Reproduction build]:
Gaia 7709936aeb21859d1607dbd038489493803bb085
Gecko https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/5bf038fae0f1
BuildID 20140522160202
Version 30.0
[6.Reproduction Frequency]:
Always Recurrence,5/5
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•10 years ago
|
||
This is the same issue we've experienced in bug 917193 and bug 988760; we've deployed a workaround for the busy tone in bug 988760 which *might* fix this issue too; I'll give it a try and see if it fixes this.
However the real issue is bug 848954 so I'm marking that as blocking.
Depends on: 848954
Comment 4•10 years ago
|
||
The patch for bug 1022554 has a wrong commit log that points to this bug, sorry about this, and sorry that I didn't check before merging :-(
Assignee | ||
Comment 5•10 years ago
|
||
This patch extends the existing workaround for glitchy short key-tones to the long ones. The day bug 848954 gets fixed and we can get rid of this stuff I'll be a happy coder. Like, real happy.
Assignee | ||
Comment 6•10 years ago
|
||
Can you try out this PR and see if it fixes the problem for you? It does for me on Flame and Hamachi devices.
Flags: needinfo?(panda67231)
Comment 7•10 years ago
|
||
Comment on attachment 8456128 [details] [diff] [review]
[PATCH] Workaround for glitchy long-press key tones
Review of attachment 8456128 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good. Literally.
Attachment #8456128 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Try was mostly green except for an unrelated integration test that I've seen failing more than once, I've re-triggered it but maybe it's time to mark it as an intermittent issue or something. Anyway pushed to gaia/master 8c702cb54f73683e9681508a8eff2d3ac9bb9109
https://github.com/mozilla-b2g/gaia/commit/8c702cb54f73683e9681508a8eff2d3ac9bb9109
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(panda67231)
You need to log in
before you can comment on or make changes to this bug.
Description
•