Closed Bug 1022466 Opened 10 years ago Closed 10 years ago

[Music] remove State Manager and restoring logic in Media App Agent in Bug 987022

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 unaffected, b2g-v2.0 unaffected, b2g-v2.1 unaffected)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed
b2g-v1.4 --- unaffected
b2g-v2.0 --- unaffected
b2g-v2.1 --- unaffected

People

(Reporter: dkuo, Assigned: dkuo)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
alive
: review+
Details
After Music inproc landed on 1.3t(bug 1002897), we should remove the fix in bug 987022 that added State Manager in Music app and the restoring logic in Media App Agent.
Only 1.3t has this so 1.3T?.
blocking-b2g: --- → 1.3T?
Attached file patch for 1.3t (deleted) —
Jim/Alive, Because music app now is inproc on 1.3t, so we should remove the fix we had in bug 987022. The Music part is entirely removed and the System part kept some logic to manage Music app's life cycle, would you please review this? thanks.
Attachment #8437427 - Flags: review?(squibblyflabbetydoo)
Attachment #8437427 - Flags: review?(alive)
Attachment #8437427 - Flags: review?(alive) → review+
let's land this dkuo :)
blocking-b2g: 1.3T? → 1.3T+
(In reply to Joe Cheng [:jcheng] from comment #3) > let's land this dkuo :) https://github.com/dominickuo/gaia/commit/6fdf145f2af17325cdd648a865ded86915c280fa
(In reply to ying.xu from comment #4) > (In reply to Joe Cheng [:jcheng] from comment #3) > > let's land this dkuo :) > > https://github.com/dominickuo/gaia/commit/ > 6fdf145f2af17325cdd648a865ded86915c280fa Thanks Ying for landing this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8437427 - Flags: review?(squibblyflabbetydoo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: