Nathan Froyd [:froydnj] Assignee
	Description • 10 years ago

      No description provided.

	Nathan Froyd [:froydnj] Assignee
	Comment 1 • 10 years ago

We already do this for mochitests, let's do it for our other suites, too!

http://mxr.mozilla.org/mozilla-central/source/testing/profiles/prefs_general.js#171

	Ed Morley [:emorley]
	Comment 2 • 10 years ago

froydnj++

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 3 • 10 years ago

Comment on attachment 8437056 [details] [diff] [review]
disable android snippets for reftests/crashtests/jsreftests

Review of attachment 8437056 [details] [diff] [review]:
-----------------------------------------------------------------

should we do this for talos as well?

	Nathan Froyd [:froydnj] Assignee
	Comment 4 • 10 years ago

(In reply to Joel Maher (:jmaher) from comment #3)
> should we do this for talos as well?

A lot of these pref settings that have been going in in service of bug 995417 should probably be ported over to talos as well, along with the eventual no-external-network environment variable setting.  But I've been focusing on mochi/ref/crash/etc. tests because those are the bulk of the tests.  Talos should be a lot easier after getting those tests in order!

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/963317561547

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd7fb786a140
https://hg.mozilla.org/releases/mozilla-beta/rev/1e5c60e57f9d
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/2666d093d7be
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/e04f006f6c61
https://hg.mozilla.org/releases/mozilla-esr24/rev/6521c72564e1

	Kamil Jozwiak [:kjozwiak]
	Comment 7 • 10 years ago

I'm going to mark this as [qa-] as this will be difficult to test locally. However, I looked over the patch in comment #3 and ensured:

js/src/tests/user.js
-> user_pref("browser.snippets.enabled", false);
-> user_pref("browser.snippets.syncPromo.enabled", false);

layout/tools/reftest/runreftest.py
-> prefs['browser.snippets.enabled'] = False
-> refs['browser.snippets.syncPromo.enabled'] = False

If someone has a way of testing this locally or knows of any test cases that could be used in this instance, please comment :)