It is currently impossible to prevent BTO from pretranslating an app. It seems that for cases like bug 1013207 it would be useful.

This patch adds PRETRANSLATION_BLACKLIST which works similar to INLINE_WHITELIST.

Comment on attachment 8440953 [details] [diff] [review] bug1022889.diff Review of attachment 8440953 [details] [diff] [review]: ----------------------------------------------------------------- r=me ::: build/webapp-optimize.js @@ +611,5 @@ > + let appName = webapp.sourceDirectoryName; > + let fileName = file.leafName; > + if (!PRETRANSLATION_BLACKLIST[appName] || > + (PRETRANSLATION_BLACKLIST[appName].indexOf('*') === -1 && > + PRETRANSLATION_BLACKLIST[appName].indexOf(fileName) === -1)) { Just for better readability, I might suggest defining a function isBlacklistedFromPretranslation(appName, fileName) which you'd call here. But if you feel it won't improve the code by much, ignore this comment.

Yeah, I don't think it'll help that much, so I prefer not to. Landing as-is. Commit: https://github.com/mozilla-b2g/gaia/commit/cbb7f268107bcd5a5c4259abdcc3bbbed975f67a Merge: https://github.com/mozilla-b2g/gaia/commit/bac9568405d34e7c9e560cc309220be753b090e3

I disagree with this fix. We have a explicit goal to remove app-specific part of build script code and information out of ./gaia/build/. If Yuren was the reviewer of this patch he would have told you that. I recommend we back this out and move the black list into somewhere like apps/keyboard/metadata.json. There isn't any tests in this bug to ensure future changes will not break this feature.

offline discissed with Tim, since we still have another three black/white list, we should file another follow up bug to migrate all black/white list to metadata.json I'll file the bug so keeping needinfo? to me

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5) > I disagree with this fix. We have a explicit goal to remove app-specific > part of build script code and information out of ./gaia/build/. If Yuren was > the reviewer of this patch he would have told you that. I recommend we back > this out and move the black list into somewhere like > apps/keyboard/metadata.json. You're right. I feel bad about not f? Yuren here. Will do better job next time! > There isn't any tests in this bug to ensure future changes will not break > this feature. Neither are for other blacklists. Or for pretranslation in general for the matter. I just followed what other blacklists in webapp-optimize do, but I like the solution described here better.

follow up bug 1027988 is filed

Clearing the ni request on me. To echo Gandalf's words: apologies for not including Yuren on this bug. It won't happen again!