Helen Huang [:HHuang] Reporter
	Description • 10 years ago

Need to update @2.25x missing images for Camera.

	Helen Huang [:HHuang] Reporter
	Comment 1 • 10 years ago

Hi Pavel,

I've updated following assets, please upload them, thanks!

./apps/camera/style/images/video_pause_button@2.25x.png
./apps/camera/style/images/video_play_button@2.25x.png
./apps/camera/style/images/video_play_focus@2.25x.png
./apps/camera/style/images/video_play_normal@2.25x.png

	Helen Huang [:HHuang] Reporter
	Comment 3 • 10 years ago

Comment on attachment 8437524 [details]
patch for Gaia/master

Thanks for helping!

	Wilson Page [:wilsonpage]
	Comment 4 • 10 years ago

Comment on attachment 8437524 [details]
patch for Gaia/master

Looks good, except the pause icon on the video controls is missing. I'm building with:

`$ make install-gaia APP=camera GAIA_DEV_PIXELS_PER_PX=2.25`

Is that correct?

I also noticed that `style/images/Video_pause_button@2x.png` looks like it has too much white-space. Could you check this out, perhaps fix with this issue?

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 5 • 10 years ago

Hey Wilson,
thanks for the feedback ... you are absolutely right ... I think that I fixed the pause icon ... but we will need new version of `style/images/Video_pause_button@2x.png` because of white space furthermore the icon have shadow.


Helen, can you help?

	Helen Huang [:HHuang] Reporter
	Comment 6 • 10 years ago

Sure! I've updated the image.

	Helen Huang [:HHuang] Reporter
	Comment 7 • 10 years ago

Hi Pavel, can you replace the image I attached?

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 8 • 10 years ago

yep ... done :)

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 9 • 10 years ago

Comment on attachment 8437524 [details]
patch for Gaia/master

think that we are OK now :) (the images are compressed too)

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 10 • 10 years ago

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/c6bfe5ded873e4ea0d46654d2c005f643eae0d8a