Carol Huang [:Carol] Reporter
	Description • 10 years ago

Missing images for keyboards.

	Carol Huang [:Carol] Reporter
	Comment 1 • 10 years ago

Hi Pavel,
Please update these images for keyboard, thanks!

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 2 • 10 years ago

Hey Helen,
the `divider.png` was 2x100 pixels and now is 1x40 pixels ... is this correct? because if it is correct we need to fix some css part of the bug

	Carol Huang [:Carol] Reporter
	Comment 3 • 10 years ago

Hi Pavel,
I revised the images again, please switch to the new one! thanks!

	Helen Huang [:HHuang]
	Comment 4 • 10 years ago

Comment on attachment 8437528 [details]
patch for Gaia/master

I've checked the latest assets that Carol attached. It looks okay!

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 5 • 10 years ago

Comment on attachment 8437528 [details]
patch for Gaia/master

I am fine with the updated assets.

However, I am kind-of curious about the new divider asset we use here, originally we use 2-pixel wide asset with some gradient and now it is only one-pixel.

Carol,
Is this by intention?

Thanks.

	Carol Huang [:Carol] Reporter
	Comment 6 • 10 years ago

Hey Rudy,
Yes, we want to use 1-pixel divider now, since the style had changed. Do you need to change coding because of this?
If so,let me know, I will revise the images. I don't want you to spend too much time on this minor changes.
Thanks!

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 7 • 10 years ago

Comment on attachment 8437528 [details]
patch for Gaia/master

No, there is code change necessary and thanks for Pavel or your effort on this.
r=me.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 8 • 10 years ago

Thanks all :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/4e7393f85b59c643a22c8db1e4a7868cc9d5ad04