Closed
Bug 1023138
Opened 10 years ago
Closed 10 years ago
[Flame][Browser]Update missing images
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(feature-b2g:2.0)
RESOLVED
FIXED
feature-b2g | 2.0 |
People
(Reporter: HHuang, Unassigned)
References
Details
Attachments
(2 files)
(deleted),
application/zip
|
Details | |
(deleted),
text/x-github-pull-request
|
benfrancis
:
review+
HHuang
:
ui-review+
|
Details |
Need to update some missing images, and replace the outdated assets.
Reporter | ||
Comment 1•10 years ago
|
||
Hi Pavel, Please help to update them, thanks!
Flags: needinfo?(pivanov)
Comment 2•10 years ago
|
||
Hey Hellen, I think we don't use `menu-pressed` images anymore, can you confirm? Because I don't see them in the code. BTW: I also compressed all images in Browser App
Attachment #8437564 -
Flags: ui-review?(hhuang)
Flags: needinfo?(pivanov)
Reporter | ||
Comment 3•10 years ago
|
||
Hi Pavel, Thanks for your reminder, I also can't find it in Browser App... Could you help to remove them? - menu.png - menu@1.5x.png - menu@2x.png - menu@2.25x.png - menu-pressed.png - menu-pressed@1.5x.png - menu-pressed@2x.png - menu-pressed@2.25x.png And I also found a updated file was wrong, please remove it. apps/browser/style/images/gradient_background@2.25x.psd
Flags: needinfo?(pivanov)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8437564 [details]
patch for Gaia/master
Thanks Pavel!
Attachment #8437564 -
Flags: ui-review?(hhuang) → ui-review+
Flags: needinfo?(hhuang)
Updated•10 years ago
|
Attachment #8437564 -
Flags: review?(bfrancis)
Updated•10 years ago
|
Attachment #8437564 -
Flags: review?(bfrancis) → review+
Comment 6•10 years ago
|
||
I've restarted some erroring Travis jobs, please land once Travis is green. If this is needed in 2.0 then approval will need to be requested. Thanks!
Comment 7•10 years ago
|
||
Thanks Ben :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/641f7d1ac37d4321f69ccb0db4ac3aedcaddadfd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 9•10 years ago
|
||
All missing and fuzzy graphics should be in for 2.0. Otherwise they count as regressions.
feature-b2g: --- → 2.0
Flags: needinfo?(swilkes)
You need to log in
before you can comment on or make changes to this bug.
Description
•