Open
Bug 1023319
Opened 11 years ago
Updated 2 years ago
Built-in widgets should not need to be specified in CustomizableWidgets.jsm in order to use the SOURCE_BUILTIN value
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
NEW
People
(Reporter: jaws, Unassigned)
References
(Blocks 1 open bug)
Details
Bug 982656 made it so that only built-in widgets can be added to a default area upon reset.
Quoting Gijs,
> So, I'm not a fan of the SOURCE_BUILTIN checking as it is, because only things
> in CustomizableWidgets.jsm will be marked as builtin. There's no way for
> external consumers elsewhere in the fx tree to create 'builtin' items. That
> sets us up for bloating CustomizableWidgets.jsm, and not being able to keep
> each widget with the rest of its feature's implementation.
> That said, I don't know how to fix this in a simple fashion. We could allow
> consumers to specify this, but the obvious problem with that is that add-ons
> might abuse it. We could potentially make AMO check for this? It's possibly
> worth consulting with Jorge or others on this. Do you have any other ideas on
> how we could correctly distinguish this?
Jorge, would it be possible for AMO to have an automated check for a widget property or function call?
Flags: needinfo?(jorge)
|
||
Comment 1•10 years ago
|
||
We have a static code validator, so we might be able to do it. I'm not sure what it is you would want us to test for, though.
Flags: needinfo?(jorge)
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•