Closed
Bug 1023359
Opened 10 years ago
Closed 10 years ago
Use touch events instead of mouse events for the battery notification
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
etienne
:
review+
|
Details | Diff | Splinter Review |
Bug 1005815 will disable mouse events coming along with touch events in the system app. This is a broken behavior on a touch device that is here more or less since the first day of touch events in Gaia.
As a result some of our code rely on this broken behavior.
|
Assignee | |
Comment 1•10 years ago
|
||
Etienne, I thought you will be a good reviewer for notifications. Let me know if I'm wrong.
Attachment #8437748 -
Flags: review?(etienne)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8437748 [details] [diff] [review]
touchstart.battery
Review of attachment 8437748 [details] [diff] [review]:
-----------------------------------------------------------------
Swiping this "notification" away already doesn't work on master (my guess is it hasn't for a while), I think we should just remove the the gesture detector here.
Attachment #8437748 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Let's remove it then.
Assignee: nobody → 21
Attachment #8437748 -
Attachment is obsolete: true
Attachment #8447177 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: NEW → ASSIGNED
|
|
||
Updated•10 years ago
|
Attachment #8447177 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•