Closed
Bug 1023472
Opened 10 years ago
Closed 3 years ago
Fix and re-enable test_bug935876.html on Android
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: RyanVM, Unassigned)
References
Details
(Whiteboard: [test disabled on Android][leave open])
Looks like bug 1021644 redux. This time bug 988616 gets to be the "regressor".
1.) Chunking changes push test into new chunk.
2.) Test starts perma-failing.
3.) Test gets disabled so we can re-open the tree.
4.) ..
5.) Profit
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Comment 1•10 years ago
|
||
Summary: Fix and re-enable test_bug935876.html on Android 2.3 → Fix and re-enable test_bug935876.html on Android
Whiteboard: [test disabled on Android 2.3][leave open] → [test disabled on Android][leave open]
Reporter | ||
Comment 2•10 years ago
|
||
Sorry, forgot to include the log link:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41456530&tree=Mozilla-Inbound
Comment 3•10 years ago
|
||
Looks like that somebody calls stopPropagation() or stopImmediatePropagation() before key events fired on <select> elements. If it's not fired in content level, they are serious regression because web apps cannot handle key events.
Merged to m-c in https://hg.mozilla.org/mozilla-central/rev/99eee26d1017
Backed out and relanded in https://hg.mozilla.org/mozilla-central/rev/b9f589c4d2e7 so I could get around m-c's commit hook requiring "a=merge" because pulling from inbound didn't create a merge commit.
Comment 5•10 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #4)
> Backed out and relanded in
> https://hg.mozilla.org/mozilla-central/rev/b9f589c4d2e7 so I could get
> around m-c's commit hook requiring "a=merge" because pulling from inbound
> didn't create a merge commit.
That diff is empty. There was no need to back anything out - just either temporarily change the tree state using treestatus, or 'hg qnew temp.diff -m "No-op merge commit for tree hook (no bug); a=merge"'. Note the commit message must contain "no bug" since the "Merge doesn't need a bug number" exception only applies if the number of heads was >1.
Reporter | ||
Comment 6•10 years ago
|
||
This is affecting mozilla-beta too now that the number of chunks was increased from 12 to 16.
Comment 7•10 years ago
|
||
FYI: Running the test even on only one platform, it's enough to test the code. So, Feel free to disable it on branches too.
Comment 8•10 years ago
|
||
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7)
> FYI: Running the test even on only one platform, it's enough to test the
> code. So, Feel free to disable it on branches too.
Oops, sorry, I posted this comment to wrong bug :-(
Comment 9•10 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
Reporter | ||
Comment 10•3 years ago
|
||
This is running on Android again nowadays.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•