Closed
Bug 1023767
Opened 10 years ago
Closed 10 years ago
HashCompleterRequest.notifyFailure doesn't work.
Categories
(Toolkit :: Safe Browsing, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: pzhang, Assigned: pzhang)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8438297 -
Flags: review?(dcamp)
|
Assignee | |
Comment 1•10 years ago
|
||
This might be duplicate of bug 832056.
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8438297 -
Flags: review?(dcamp) → review?(mmc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8438297 [details] [diff] [review]
0001-Fix-bug-HashCompleterRequest.notifyFailure-doesn-t-w.patch
Pin, thank you for fixing this bug that has been present since 2011. Were you able to verify that this patch solved the hanging gethash problem?
Attachment #8438297 -
Flags: review?(mmc) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to [:mmc] Monica Chew (please use needinfo) from comment #2)
> Comment on attachment 8438297 [details] [diff] [review]
> 0001-Fix-bug-HashCompleterRequest.notifyFailure-doesn-t-w.patch
>
> Pin, thank you for fixing this bug that has been present since 2011. Were
> you able to verify that this patch solved the hanging gethash problem?
No, in that case, onStopRequest never got invoked.
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Assignee: nobody → pzhang
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•