Closed Bug 1024295 Opened 10 years ago Closed 10 years ago

[bb][header] Missing images

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(2 files)

      No description provided.
No longer blocks: 1023140
Hey Fang,

We need to check Headers images ... take a look here:
https://github.com/mozilla-b2g/gaia/tree/master/shared/style/headers/images/icons

Some of the Apps like Email use icons from header
Blocks: 1023140
Hi Pavel,

For Email header, icon, the back and next arrows are the only missing icon, and I already attached in bug 1023140 comment 7. Thanks!
Yep,
I work on a patch now ... I just want to check all images in header :) 

Thanks :)
Attached file patch for Gaia/master (deleted) —
Attachment #8438980 - Flags: ui-review?(fshih)
Comment on attachment 8438980 [details]
patch for Gaia/master

Header icons are looking sharp now!
But noticed that all the tab icons are fuzzy now? Or it just happened on this patch only? Since this is a bug of header images. Just want to double confirm : ) Thanks!
Attachment #8438980 - Flags: ui-review?(fshih) → ui-review+
Hey Fang,

the replay icons are part from the Headers too.
we also need for the headers following version of icons:

add@2x.png
clear@2x.png
clear@2.25x.png
edit@2x.png
options@2x.png
reply.png@2.25x.png
reply_all@2.25x.png
user@2x.png
Flags: needinfo?(fshih)
What do you mean by `tab icons`?
Attached file Header missing images.zip (deleted) —
Hi Pavel, images have been updated.
Flags: needinfo?(fshih) → needinfo?(pivanov)
Attachment #8438980 - Flags: review?(arnau)
Flags: needinfo?(pivanov)
(In reply to Pavel Ivanov [:ivanovpavel] from comment #7)
> What do you mean by `tab icons`?

Sorry, I mean to say tool bar icons. 
After our offline discussed, once the bug 1023140 landed, the tool bar​ icon will be good! I have no question now :-) Thanks a lot!
Pavel, have some comments in github :)
Done :)
Flags: needinfo?(arnau)
Comment on attachment 8438980 [details]
patch for Gaia/master

Thanks Pavel. LGTM!
Attachment #8438980 - Flags: review?(arnau) → review+
Flags: needinfo?(arnau)
Thanks :) 

Landed to master:
https://github.com/pivanov/gaia/tree/bug-1024295
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: