Closed Bug 1024428 Opened 10 years ago Closed 10 years ago

[WebComponents] Browser crashes when <input type="range" /> in shadow-dom

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla34

People

(Reporter: wilsonpage, Assigned: smaug)

References

Details

(Whiteboard: [2.1-feature-qa+])

Attachments

(3 files)

testcase
(deleted), text/html
Details
patch
(deleted), patch
wchen
: review+
Details | Diff | Splinter Review
for checkin
(deleted), patch
Details | Diff | Splinter Review
Blocks: 1021747
Couldn't reproduce on linux, but testing a debug build in a minute.
This is on Mac Nightly. (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #1) > WFM. Needs a crash report. Where do I get a crash report from?
Couldn't reproduce with a debug build either, and no assertions or warnings either. For a crash report - you should get one when Nightly crashes, and about:crashes has the id for it.
(In reply to Olli Pettay [:smaug] from comment #4) > Couldn't reproduce with a debug build either, and no assertions or warnings > either. > > > For a crash report - you should get one when Nightly crashes, and > about:crashes has the id for it. Here's the crash-report: https://crash-stats.mozilla.com/report/index/a6967bbe-a9a1-4d87-ad1d-08db12140612
Blocks: 992521
Oh, the testcase looks wrong. It has type="text"
Attached file testcase (deleted) —
Keywords: stackwanted
> nsRangeFrame::MakeAnonymousDiv > nsCOMPtr<nsIDocument> doc = mContent->GetDocument(); doc is now null. That's not OK for something with a frame. If it's got a frame, it needs to have a non-null GetCurrentDoc(). Layout code depends on that all over...
And ccing Jonas, since he apparently argued for this state of things.
Attached patch patch (deleted) — — Splinter Review
We need some other fixes to get the look right, but lets start with this.
Assignee: nobody → bugs
Attachment #8463607 - Flags: review?(wchen)
Comment on attachment 8463607 [details] [diff] [review] patch Review of attachment 8463607 [details] [diff] [review]: ----------------------------------------------------------------- This fixes the crash, but we still need to figure out what we need to do to make to form control actually work as expected.
Attachment #8463607 - Flags: review?(wchen) → review+
well, range does work. It just looks a bit wrong during dragging
Oh, the odd looking painting isn't even related to shadow DOM. It happens on linux in normal dom too.
Attached patch for checkin (deleted) — — Splinter Review
https://hg.mozilla.org/mozilla-central/rev/f502be80b687
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [2.1-feature-qa+]
QA Whiteboard: [2.1-feature-qa+] → [2.1-feature-qa-]
QA Whiteboard: [2.1-feature-qa-]
Whiteboard: [2.1-feature-qa+]
Flags: in-moztrap-
Marking verified since there's no QA support planned to be done here, so verification isn't needed here.
Status: RESOLVED → VERIFIED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: