Closed
Bug 1024787
Opened 11 years ago
Closed 10 years ago
Fix uncaught promise rejections in DevTools framework
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: jsantell, Assigned: jsantell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
When uncaught promise rejections throw errors, the following occur in framework:
0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_devtools_api.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:901 - TypeError: this.doc is undefined
0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_new_activation_workflow.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:901 - TypeError: this.doc is undefined
0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
0:38.28 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
0:38.28 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
The keybinding test is tracked in bug 991075
0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_keybindings.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:901 - TypeError: this.doc is undefined
Assignee | ||
Comment 1•11 years ago
|
||
Making a new bug (bug 1024789) for the remaining devtools/framework promise failure, as it seems like it may be in a different tool, and much larger than these.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
Comment on attachment 8439601 [details] [diff] [review]
1024787-devtools-framework-rejections.patch
Review of attachment 8439601 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/framework/test/browser_devtools_api.js
@@ -42,4 @@
> is(toolbox.target, target, "toolbox target is correct");
> is(toolbox._host.hostTab, gBrowser.selectedTab, "toolbox host is correct");
> continueTests(toolbox);
> - }).then(null, console.error);
Why remove this? Isn't it needed to log any rejections?
@@ -73,2 @@
> finishUp();
> - }).then(null, console.error);
Same here.
Attachment #8439601 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 3•11 years ago
|
||
With the patch in bug 991040 lands, uncaught errors will throw, so we'll see them there (which is why we're fixing these uncaught rejections in bug 1018184, correct me if I'm misunderstanding)
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #3)
> With the patch in bug 991040 lands, uncaught errors will throw, so we'll see
> them there (which is why we're fixing these uncaught rejections in bug
> 1018184, correct me if I'm misunderstanding)
Haha, yes, makes sense. Too late in the day for thinking clearly...
Assignee | ||
Comment 5•11 years ago
|
||
:D
Attachment #8439601 -
Attachment is obsolete: true
Attachment #8439629 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 7•11 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•