Closed
Bug 1025139
Opened 10 years ago
Closed 10 years ago
WifiCertService.cpp uses unexported NSS symbols
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
WifiCertService.cpp calls CERT_AddTempCertToPerm:
http://mxr.mozilla.org/mozilla-central/source/dom/wifi/WifiCertService.cpp#153
which isn't really exported from NSS:
http://mxr.mozilla.org/mozilla-central/source/security/nss/lib/nss/nss.def#545
http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSCertificateDB.cpp#5
But since we don't use linker scripts to limit visibility to what nss.def specifies on B2G, CERT_AddTempCertToPerm is merrily exported alongside __CERT_AddTempCertToPerm.
...at least, until things like bug 1018375 want to enforce what nss.def specifies on B2G.
I guess the way forward here it to add the same #define bit that nsNSSCertificateDB.cpp uses to WifiCertService.cpp, so we are at least consistently using the same symbol in PSM and dom/wifi/? Does that sound right?
Flags: needinfo?(brian)
Assignee | ||
Comment 2•10 years ago
|
||
This is a hack, but it is a hack with precedent, at least...
Attachment #8440103 -
Flags: review?(bzbarsky)
Is there some reason we can't export CERT_AddTempCertToPerm from NSS?
Comment 4•10 years ago
|
||
Comment on attachment 8440103 [details] [diff] [review]
use the correct symbol for CERT_AddTempCertToPerm in WifiCertService.cpp
r=me if we can't get this symbol actually exported.
Attachment #8440103 -
Flags: review?(bzbarsky) → review+
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nfroyd
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•