Closed
Bug 1025349
Opened 10 years ago
Closed 10 years ago
Potential out of bounds read in ccsnap_get_line_label and ccsnap_set_line_label
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: erahm, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 749130][CID 749131])
Attachments
(1 file)
|
(deleted),
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
Off by one, test should be <, not <=:
if ( btn > 0 && btn < MAX_CONFIG_LINES+1 ) {
|
Reporter | |
Updated•10 years ago
|
Summary: Potential out of bounds read in ccsnap_get_line_label → Potential out of bounds read in ccsnap_get_line_label and ccsnap_set_line_label
Whiteboard: [CID 749130] → [CID 749130][CID 749131]
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Easier to fix this than prove it's not used (and I'm pretty sure it's not).
Assignee: nobody → rjesup
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8440239 -
Flags: review?(ethanhugg)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8440239 [details] [diff] [review] fix error in ccsnap line label indexes Review of attachment 8440239 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8440239 -
Flags: review?(ethanhugg) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a1b1128c23
Target Milestone: --- → mozilla33
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/95a1b1128c23
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•